Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: android_webview/renderer/aw_render_view_ext.cc

Issue 1259673002: Make UTF16ToASCII and UTF16TOUTF8 take a StringPiece (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/renderer/aw_content_renderer_client.cc ('k') | base/strings/utf_string_conversions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/renderer/aw_render_view_ext.cc
diff --git a/android_webview/renderer/aw_render_view_ext.cc b/android_webview/renderer/aw_render_view_ext.cc
index b91b8abfe3aa18c50b15748276a9c1c614686253..ac377253e24b3351b7f070fbfae5bff3e26ffbf6 100644
--- a/android_webview/renderer/aw_render_view_ext.cc
+++ b/android_webview/renderer/aw_render_view_ext.cc
@@ -80,9 +80,8 @@ bool RemovePrefixAndAssignIfMatches(const base::StringPiece& prefix,
url::DecodeURLEscapeSequences(spec.data() + prefix.length(),
spec.length() - prefix.length(),
&output);
- std::string decoded_url = base::UTF16ToUTF8(
- base::string16(output.data(), output.length()));
- dest->assign(decoded_url.begin(), decoded_url.end());
+ *dest = base::UTF16ToUTF8(
+ base::StringPiece16(output.data(), output.length()));
return true;
}
return false;
« no previous file with comments | « android_webview/renderer/aw_content_renderer_client.cc ('k') | base/strings/utf_string_conversions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698