Make UTF16ToASCII and UTF16TOUTF8 take a StringPiece

content/renderer/accessibility/blink_ax_tree_source.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/accessibility/blink_ax_tree_source.h"
 
 #include <set>
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ skipping 206 matching lines @@
 blink::WebAXObject BlinkAXTreeSource::GetNull() const {
   return blink::WebAXObject();
 }
 
 void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,
                                       ui::AXNodeData* dst) const {
   dst->role = AXRoleFromBlink(src.role());
   dst->state = AXStateFromBlink(src);
   dst->location = src.boundingBoxRect();
   dst->id = src.axID();
-  std::string name = UTF16ToUTF8(src.deprecatedTitle());
+  std::string name = UTF16ToUTF8(base::StringPiece16(src.deprecatedTitle()));
 
   std::string value;
   if (src.valueDescription().length()) {
     dst->AddStringAttribute(ui::AX_ATTR_VALUE,
-                            UTF16ToUTF8(src.valueDescription()));
+                            UTF16ToUTF8(base::StringPiece16(
+                                src.valueDescription())));
   } else {
-    dst->AddStringAttribute(ui::AX_ATTR_VALUE, UTF16ToUTF8(src.stringValue()));
+    dst->AddStringAttribute(
+        ui::AX_ATTR_VALUE,
+        UTF16ToUTF8(base::StringPiece16(src.stringValue())));
   }
 
   if (dst->role == ui::AX_ROLE_COLOR_WELL)
     dst->AddIntAttribute(ui::AX_ATTR_COLOR_VALUE, src.colorValue());
 
 
   // Text attributes.
   if (src.backgroundColor())
     dst->AddIntAttribute(ui::AX_ATTR_BACKGROUND_COLOR, src.backgroundColor());
 
   if (src.color())
     dst->AddIntAttribute(ui::AX_ATTR_COLOR, src.color());
 
   // Font size is in pixels.
   if (src.fontSize())
     dst->AddFloatAttribute(ui::AX_ATTR_FONT_SIZE, src.fontSize());
 
   if (src.invalidState()) {
     dst->AddIntAttribute(ui::AX_ATTR_INVALID_STATE,
                          AXInvalidStateFromBlink(src.invalidState()));
   }
   if (src.invalidState() == blink::WebAXInvalidStateOther) {
-    dst->AddStringAttribute(ui::AX_ATTR_ARIA_INVALID_VALUE,
-                            UTF16ToUTF8(src.ariaInvalidValue()));
+    dst->AddStringAttribute(
+        ui::AX_ATTR_ARIA_INVALID_VALUE,
+        UTF16ToUTF8(base::StringPiece16(src.ariaInvalidValue())));
   }
 
   if (src.textDirection()) {
     dst->AddIntAttribute(ui::AX_ATTR_TEXT_DIRECTION,
                          AXTextDirectionFromBlink(src.textDirection()));
   }
 
   if (src.textStyle()) {
     dst->AddIntAttribute(ui::AX_ATTR_TEXT_STYLE,
                          AXTextStyleFromBlink(src.textStyle()));
@@ skipping 19 matching lines @@
     for (size_t i = 0; i < src_word_starts.size(); ++i) {
       word_starts.push_back(src_word_starts[i]);
       word_ends.push_back(src_word_ends[i]);
     }
     dst->AddIntListAttribute(ui::AX_ATTR_WORD_STARTS, word_starts);
     dst->AddIntListAttribute(ui::AX_ATTR_WORD_ENDS, word_ends);
   }
 
   if (src.accessKey().length()) {
     dst->AddStringAttribute(ui::AX_ATTR_ACCESS_KEY,
-    UTF16ToUTF8(src.accessKey()));
+    UTF16ToUTF8(base::StringPiece16(src.accessKey())));
   }
 
   if (src.actionVerb().length())
-    dst->AddStringAttribute(ui::AX_ATTR_ACTION, UTF16ToUTF8(src.actionVerb()));
+    dst->AddStringAttribute(
+        ui::AX_ATTR_ACTION,
+        UTF16ToUTF8(base::StringPiece16(src.actionVerb())));
   if (src.ariaAutoComplete().length())
-    dst->AddStringAttribute(ui::AX_ATTR_AUTO_COMPLETE,
-                            UTF16ToUTF8(src.ariaAutoComplete()));
+    dst->AddStringAttribute(
+        ui::AX_ATTR_AUTO_COMPLETE,
+        UTF16ToUTF8(base::StringPiece16(src.ariaAutoComplete())));
   if (src.isAriaReadOnly())
     dst->AddBoolAttribute(ui::AX_ATTR_ARIA_READONLY, true);
   if (src.isButtonStateMixed())
     dst->AddBoolAttribute(ui::AX_ATTR_BUTTON_MIXED, true);
   if (src.canSetValueAttribute())
     dst->AddBoolAttribute(ui::AX_ATTR_CAN_SET_VALUE, true);
   if (src.deprecatedAccessibilityDescription().length()) {
     dst->AddStringAttribute(
         ui::AX_ATTR_DESCRIPTION,
-        UTF16ToUTF8(src.deprecatedAccessibilityDescription()));
+        UTF16ToUTF8(base::StringPiece16(
+            src.deprecatedAccessibilityDescription())));
   }
   if (src.hasComputedStyle()) {
-    dst->AddStringAttribute(ui::AX_ATTR_DISPLAY,
-                            UTF16ToUTF8(src.computedStyleDisplay()));
+    dst->AddStringAttribute(
+        ui::AX_ATTR_DISPLAY,
+        UTF16ToUTF8(base::StringPiece16(src.computedStyleDisplay())));
   }
   if (src.deprecatedHelpText().length())
-    dst->AddStringAttribute(ui::AX_ATTR_HELP,
-                            UTF16ToUTF8(src.deprecatedHelpText()));
+    dst->AddStringAttribute(
+        ui::AX_ATTR_HELP,
+        UTF16ToUTF8(base::StringPiece16((src.deprecatedHelpText()))));
   if (src.deprecatedPlaceholder().length()) {
-    dst->AddStringAttribute(ui::AX_ATTR_PLACEHOLDER,
-                            UTF16ToUTF8(src.deprecatedPlaceholder()));
+    dst->AddStringAttribute(
+        ui::AX_ATTR_PLACEHOLDER,
+        UTF16ToUTF8(base::StringPiece16(src.deprecatedPlaceholder())));
   }
   if (src.keyboardShortcut().length()) {
-    dst->AddStringAttribute(ui::AX_ATTR_SHORTCUT,
-                            UTF16ToUTF8(src.keyboardShortcut()));
+    dst->AddStringAttribute(
+        ui::AX_ATTR_SHORTCUT,
+        UTF16ToUTF8(base::StringPiece16(src.keyboardShortcut())));
   }
   if (!src.deprecatedTitleUIElement().isDetached()) {
     dst->AddIntAttribute(ui::AX_ATTR_TITLE_UI_ELEMENT,
                          src.deprecatedTitleUIElement().axID());
   }
   if (!src.ariaActiveDescendant().isDetached()) {
     dst->AddIntAttribute(ui::AX_ATTR_ACTIVEDESCENDANT_ID,
                          src.ariaActiveDescendant().axID());
   }
 
@@ skipping 29 matching lines @@
 
   if (!node.isNull() && node.isElementNode()) {
     WebElement element = node.to<WebElement>();
     is_iframe = (element.tagName() == ASCIIToUTF16("IFRAME"));
 
     // TODO(ctguil): The tagName in WebKit is lower cased but
     // HTMLElement::nodeName calls localNameUpper. Consider adding
     // a WebElement method that returns the original lower cased tagName.
     dst->AddStringAttribute(
         ui::AX_ATTR_HTML_TAG,
-        base::StringToLowerASCII(UTF16ToUTF8(element.tagName())));
+        base::StringToLowerASCII(UTF16ToUTF8(
+            base::StringPiece16(element.tagName()))));
     for (unsigned i = 0; i < element.attributeCount(); ++i) {
       std::string name = base::StringToLowerASCII(UTF16ToUTF8(
-          element.attributeLocalName(i)));
-      std::string value = UTF16ToUTF8(element.attributeValue(i));
+          base::StringPiece16(element.attributeLocalName(i))));
+      std::string value =
+          UTF16ToUTF8(base::StringPiece16(element.attributeValue(i)));
       dst->html_attributes.push_back(std::make_pair(name, value));
     }
 
     if (!src.isReadOnly() || dst->role == ui::AX_ROLE_TEXT_FIELD) {
       dst->AddIntAttribute(ui::AX_ATTR_TEXT_SEL_START, src.selectionStart());
       dst->AddIntAttribute(ui::AX_ATTR_TEXT_SEL_END, src.selectionEnd());
 
       WebVector<int> src_line_breaks;
       src.lineBreaks(src_line_breaks);
       if (src_line_breaks.size() > 0) {
         std::vector<int32> line_breaks;
         line_breaks.reserve(src_line_breaks.size());
         for (size_t i = 0; i < src_line_breaks.size(); ++i)
           line_breaks.push_back(src_line_breaks[i]);
         dst->AddIntListAttribute(ui::AX_ATTR_LINE_BREAKS, line_breaks);
       }
     }
 
     // ARIA role.
     if (element.hasAttribute("role")) {
-      dst->AddStringAttribute(ui::AX_ATTR_ROLE,
-                              UTF16ToUTF8(element.getAttribute("role")));
+      dst->AddStringAttribute(
+          ui::AX_ATTR_ROLE,
+          UTF16ToUTF8(base::StringPiece16(element.getAttribute("role"))));
     } else {
       std::string role = GetEquivalentAriaRoleString(dst->role);
       if (!role.empty())
         dst->AddStringAttribute(ui::AX_ATTR_ROLE, role);
       else if (dst->role == ui::AX_ROLE_TIME)
         dst->AddStringAttribute(ui::AX_ATTR_ROLE, "time");
     }
 
     // Browser plugin (used in a <webview>).
     if (node_to_browser_plugin_instance_id_map_) {
@@ skipping 20 matching lines @@
       }
     }
   }
 
   if (src.isInLiveRegion()) {
     dst->AddBoolAttribute(ui::AX_ATTR_LIVE_ATOMIC, src.liveRegionAtomic());
     dst->AddBoolAttribute(ui::AX_ATTR_LIVE_BUSY, src.liveRegionBusy());
     if (src.liveRegionBusy())
       dst->state |= (1 << ui::AX_STATE_BUSY);
     if (!src.liveRegionStatus().isEmpty()) {
-      dst->AddStringAttribute(ui::AX_ATTR_LIVE_STATUS,
-                              UTF16ToUTF8(src.liveRegionStatus()));
+      dst->AddStringAttribute(
+          ui::AX_ATTR_LIVE_STATUS,
+          UTF16ToUTF8(base::StringPiece16(src.liveRegionStatus())));
     }
-    dst->AddStringAttribute(ui::AX_ATTR_LIVE_RELEVANT,
-                            UTF16ToUTF8(src.liveRegionRelevant()));
+    dst->AddStringAttribute(
+        ui::AX_ATTR_LIVE_RELEVANT,
+        UTF16ToUTF8(base::StringPiece16(src.liveRegionRelevant())));
     dst->AddBoolAttribute(ui::AX_ATTR_CONTAINER_LIVE_ATOMIC,
                           src.containerLiveRegionAtomic());
     dst->AddBoolAttribute(ui::AX_ATTR_CONTAINER_LIVE_BUSY,
                           src.containerLiveRegionBusy());
-    dst->AddStringAttribute(ui::AX_ATTR_CONTAINER_LIVE_STATUS,
-                            UTF16ToUTF8(src.containerLiveRegionStatus()));
-    dst->AddStringAttribute(ui::AX_ATTR_CONTAINER_LIVE_RELEVANT,
-                            UTF16ToUTF8(src.containerLiveRegionRelevant()));
+    dst->AddStringAttribute(
+        ui::AX_ATTR_CONTAINER_LIVE_STATUS,
+        UTF16ToUTF8(base::StringPiece16(src.containerLiveRegionStatus())));
+    dst->AddStringAttribute(
+        ui::AX_ATTR_CONTAINER_LIVE_RELEVANT,
+        UTF16ToUTF8(base::StringPiece16(src.containerLiveRegionRelevant())));
   }
 
   if (dst->role == ui::AX_ROLE_PROGRESS_INDICATOR ||
       dst->role == ui::AX_ROLE_METER ||
       dst->role == ui::AX_ROLE_SCROLL_BAR ||
       dst->role == ui::AX_ROLE_SLIDER ||
       dst->role == ui::AX_ROLE_SPIN_BUTTON) {
     dst->AddFloatAttribute(ui::AX_ATTR_VALUE_FOR_RANGE, src.valueForRange());
     dst->AddFloatAttribute(ui::AX_ATTR_MAX_VALUE_FOR_RANGE,
                            src.maxValueForRange());
     dst->AddFloatAttribute(ui::AX_ATTR_MIN_VALUE_FOR_RANGE,
                            src.minValueForRange());
   }
 
   if (dst->role == ui::AX_ROLE_WEB_AREA) {
     dst->AddStringAttribute(ui::AX_ATTR_HTML_TAG, "#document");
     const WebDocument& document = src.document();
     if (name.empty())
-      name = UTF16ToUTF8(document.title());
-    dst->AddStringAttribute(ui::AX_ATTR_DOC_TITLE,
-                            UTF16ToUTF8(document.title()));
+      name = UTF16ToUTF8(base::StringPiece16(document.title()));
+    dst->AddStringAttribute(
+        ui::AX_ATTR_DOC_TITLE,
+        UTF16ToUTF8(base::StringPiece16(document.title())));
     dst->AddStringAttribute(ui::AX_ATTR_DOC_URL, document.url().spec());
     dst->AddStringAttribute(
         ui::AX_ATTR_DOC_MIMETYPE,
         document.isXHTMLDocument() ? "text/xhtml" : "text/html");
     dst->AddBoolAttribute(ui::AX_ATTR_DOC_LOADED, src.isLoaded());
     dst->AddFloatAttribute(ui::AX_ATTR_DOC_LOADING_PROGRESS,
                            src.estimatedLoadingProgress());
 
     const WebDocumentType& doctype = document.doctype();
     if (!doctype.isNull()) {
-      dst->AddStringAttribute(ui::AX_ATTR_DOC_DOCTYPE,
-                              UTF16ToUTF8(doctype.name()));
+      dst->AddStringAttribute(
+          ui::AX_ATTR_DOC_DOCTYPE,
+          UTF16ToUTF8(base::StringPiece16(doctype.name())));
     }
 
   }
 
   if (dst->role == ui::AX_ROLE_TABLE) {
     int column_count = src.columnCount();
     int row_count = src.rowCount();
     if (column_count > 0 && row_count > 0) {
       std::set<int32> unique_cell_id_set;
       std::vector<int32> cell_ids;
@@ skipping 111 matching lines @@
   }
 }
 
 blink::WebDocument BlinkAXTreeSource::GetMainDocument() const {
   if (render_frame_ && render_frame_->GetWebFrame())
     return render_frame_->GetWebFrame()->document();
   return WebDocument();
 }
 
 }  // namespace content