Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1259653004: remove flags that control no code (Closed)

Created:
5 years, 4 months ago by reed1
Modified:
5 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove flags that control no code BUG=skia: Committed: https://skia.googlesource.com/skia/+/e00368018d993680017f425701f992f41bfa8d71

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M gyp/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/pdf.gyp View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
reed1
5 years, 4 months ago (2015-08-03 20:36:53 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259653004/1
5 years, 4 months ago (2015-08-03 20:37:07 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-03 20:45:39 UTC) #6
mtklein
lgtm https://codereview.chromium.org/1259653004/diff/1/gyp/pdf.gyp File gyp/pdf.gyp (right): https://codereview.chromium.org/1259653004/diff/1/gyp/pdf.gyp#newcode48 gyp/pdf.gyp:48: # This section makes all targets that depend ...
5 years, 4 months ago (2015-08-03 20:57:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259653004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259653004/20001
5 years, 4 months ago (2015-08-03 21:28:27 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 21:44:35 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e00368018d993680017f425701f992f41bfa8d71

Powered by Google App Engine
This is Rietveld 408576698