Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: content/browser/android/web_contents_observer_proxy.cc

Issue 1259633002: NOT FOR LANDING Implement WebMediaSession (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: hack until something works Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/web_contents_observer_proxy.cc
diff --git a/content/browser/android/web_contents_observer_proxy.cc b/content/browser/android/web_contents_observer_proxy.cc
index adfa2aaaf4d67dd4c889f9621dfcdcecf5acd30f..e856d8e4ef79b382305bdb5041a4cf88aa5e0c9d 100644
--- a/content/browser/android/web_contents_observer_proxy.cc
+++ b/content/browser/android/web_contents_observer_proxy.cc
@@ -293,6 +293,10 @@ void WebContentsObserverProxy::MediaSessionStateChanged(bool is_controllable,
ScopedJavaLocalRef<jobject> obj(java_observer_);
+ // TODO(philipj): This is where we cross from content/ to chrome/, i.e. where
+ // Chrome and Opera will have different UIs. Need to send all relevant
+ // information here, i.e. the metadata for Blink-created media sessions, and
+ // the tab title and other information for the default media session.
mlamouri (slow - plz ping) 2015/08/24 12:55:24 tab title should be available from WebContents. I
whywhat 2015/08/24 14:39:18 It might make sense to send media session metadata
philipj_slow 2015/08/26 07:39:48 Right, when I wrote this comment, I was thinking t
Java_WebContentsObserverProxy_mediaSessionStateChanged(
env, obj.obj(), is_controllable, is_suspended);
}

Powered by Google App Engine
This is Rietveld 408576698