Change RecordSlot interface. Make it more robust by replacing anchor slot with actual object.

Change RecordSlot interface. Make it more robust by replacing anchor slot with actual object.

BUG=

Committed: https://crrev.com/c7456abf464265cf7f2454a1a1d16e835d161566
Cr-Commit-Position: refs/heads/master@{#30007}

[Hannes Payer (out of office), 2015-08-04 14:54:18]

hpayer@chromium.org changed reviewers:
+ mstarzinger@chromium.org, ulan@chromium.org

[Michael Starzinger, 2015-08-04 15:20:13]

LGTM. Only nits. I love it.

https://codereview.chromium.org/1259613006/diff/60001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1259613006/diff/60001/src/heap/heap.cc#newcod...
src/heap/heap.cc:5153: Object* new_object = *slot;
nit: s/new_object/new_target/ for consistency.

https://codereview.chromium.org/1259613006/diff/60001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1259613006/diff/60001/src/heap/heap.h#newcode955
src/heap/heap.h:955: // from start to end of |object|.
nit: s/of/within/, otherwise it sounds like "end of object", which is
misleading.

https://codereview.chromium.org/1259613006/diff/60001/src/heap/mark-compact-i...
File src/heap/mark-compact-inl.h (right):

https://codereview.chromium.org/1259613006/diff/60001/src/heap/mark-compact-i...
src/heap/mark-compact-inl.h:58: void
MarkCompactCollector::RecordSlot(HeapObject* source, Object** slot,
nit: s/source/object/ for consistency.

https://codereview.chromium.org/1259613006/diff/60001/src/heap/mark-compact.h
File src/heap/mark-compact.h (left):

https://codereview.chromium.org/1259613006/diff/60001/src/heap/mark-compact.h...
src/heap/mark-compact.h:643: INLINE(static bool
ShouldSkipEvacuationSlotRecording(Object** anchor)) {
Woot! I love it!

https://codereview.chromium.org/1259613006/diff/60001/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):

https://codereview.chromium.org/1259613006/diff/60001/src/heap/mark-compact.h...
src/heap/mark-compact.h:658: HeapObject* source, Object** slot, Object* target,
nit: s/source/object/ for consistency.

https://codereview.chromium.org/1259613006/diff/60001/src/heap/objects-visiti...
File src/heap/objects-visiting.h (right):

https://codereview.chromium.org/1259613006/diff/60001/src/heap/objects-visiti...
src/heap/objects-visiting.h:300: INLINE(static void VisitPointers(Heap* heap,
HeapObject* object,
Is this change for the StaticNewSpaceVisitor really necessary? This one should
never be applied to LO-space objects. The StaticNewSpaceVisitor is independent
from the StaticMarkingVisitor and hence its interface can be (and already is)
out of sync.

[ulan, 2015-08-04 16:09:22]

lgtm!

https://codereview.chromium.org/1259613006/diff/60001/src/heap/incremental-ma...
File src/heap/incremental-marking.cc (right):

https://codereview.chromium.org/1259613006/diff/60001/src/heap/incremental-ma...
src/heap/incremental-marking.cc:216: Object* obj = *p;
s/obj/target here and in the function below to avoid confusion with object.

[Hannes Payer (out of office), 2015-08-04 16:16:21]

https://codereview.chromium.org/1259613006/diff/60001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1259613006/diff/60001/src/heap/heap.cc#newcod...
src/heap/heap.cc:5153: Object* new_object = *slot;
On 2015/08/04 15:20:12, Michael Starzinger wrote:
> nit: s/new_object/new_target/ for consistency.

Done.

https://codereview.chromium.org/1259613006/diff/60001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1259613006/diff/60001/src/heap/heap.h#newcode955
src/heap/heap.h:955: // from start to end of |object|.
On 2015/08/04 15:20:12, Michael Starzinger wrote:
> nit: s/of/within/, otherwise it sounds like "end of object", which is
> misleading.

Done.

https://codereview.chromium.org/1259613006/diff/60001/src/heap/incremental-ma...
File src/heap/incremental-marking.cc (right):

https://codereview.chromium.org/1259613006/diff/60001/src/heap/incremental-ma...
src/heap/incremental-marking.cc:216: Object* obj = *p;
On 2015/08/04 16:09:22, ulan wrote:
> s/obj/target here and in the function below to avoid confusion with object.

Done.

https://codereview.chromium.org/1259613006/diff/60001/src/heap/mark-compact-i...
File src/heap/mark-compact-inl.h (right):

https://codereview.chromium.org/1259613006/diff/60001/src/heap/mark-compact-i...
src/heap/mark-compact-inl.h:58: void
MarkCompactCollector::RecordSlot(HeapObject* source, Object** slot,
On 2015/08/04 15:20:12, Michael Starzinger wrote:
> nit: s/source/object/ for consistency.

Done.

https://codereview.chromium.org/1259613006/diff/60001/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):

https://codereview.chromium.org/1259613006/diff/60001/src/heap/mark-compact.h...
src/heap/mark-compact.h:658: HeapObject* source, Object** slot, Object* target,
On 2015/08/04 15:20:12, Michael Starzinger wrote:
> nit: s/source/object/ for consistency.

Done.

https://codereview.chromium.org/1259613006/diff/60001/src/heap/objects-visiti...
File src/heap/objects-visiting.h (right):

https://codereview.chromium.org/1259613006/diff/60001/src/heap/objects-visiti...
src/heap/objects-visiting.h:300: INLINE(static void VisitPointers(Heap* heap,
HeapObject* object,
On 2015/08/04 15:20:13, Michael Starzinger wrote:
> Is this change for the StaticNewSpaceVisitor really necessary? This one should
> never be applied to LO-space objects. The StaticNewSpaceVisitor is independent
> from the StaticMarkingVisitor and hence its interface can be (and already is)
> out of sync.

Unfortunatly, BodyVisitorBase is used by both. We have to add it also to the new
space visitor.

[Hannes Payer (out of office), 2015-08-04 16:16:27]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2015-08-04 16:16:27]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1259613006/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-08-04 16:16:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1259613006/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1259613006/100001

[commit-bot: I haz the power, 2015-08-04 16:42:16]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-08-04 16:43:33]

Patchset 6 (id:??) landed as
https://crrev.com/c7456abf464265cf7f2454a1a1d16e835d161566
Cr-Commit-Position: refs/heads/master@{#30007}