Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1259613004: Merge devtoolslib/apptest_runner.py into mojo_test. (Closed)

Created:
5 years, 4 months ago by ppi
Modified:
5 years, 4 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Merge devtoolslib/apptest_runner.py into mojo_test. Now that `mojo_test` is the intended way of consuming apptest support, no need to have a library function. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b2b420b1fc3c9ccbb00507a410933cbb28ff8175

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -68 lines) Patch
D mojo/devtools/common/devtoolslib/apptest_runner.py View 1 chunk +0 lines, -61 lines 0 comments Download
M mojo/devtools/common/mojo_test View 2 chunks +41 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ppi
Hi Ben, ptal.
5 years, 4 months ago (2015-07-29 09:27:06 UTC) #1
qsr
lgtm
5 years, 4 months ago (2015-07-29 10:08:24 UTC) #2
ppi
5 years, 4 months ago (2015-07-29 10:52:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b2b420b1fc3c9ccbb00507a410933cbb28ff8175 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698