Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1259613002: Revert of Hook up the Push API with GCM's new ability to own encryption keys. (Closed)

Created:
5 years, 5 months ago by Peter Beverloo
Modified:
5 years, 5 months ago
CC:
chromium-reviews, mvanouwerkerk+watch_chromium.org, peter+watch_chromium.org, johnme+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gcm-encryption
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Hook up the Push API with GCM's new ability to own encryption keys. (patchset #6 id:160001 of https://codereview.chromium.org/1231613005/) Reason for revert: I broke the build. Sorry! http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/3129/steps/compile/logs/stdio#error1 Original issue's description: > Hook up the Push API with GCM's new ability to own encryption keys. > > This CL finishes implementing propagation of the "curve25519dh" attribute > of the PushSubscription interface of the Push API. The public key will be > provided by the GCM Driver, which internally uses the (new) GCMKeyStore. > > Encrypted messages cannot yet be received by GCM - that work remains. The > functionality introduced in this CL is also still guarded behind the > "--enable-push-message-payload" command line flag. > > BUG=486040 > > Committed: https://crrev.com/23695aaa72c3c7c5176456c5ca4d3f7617be42fd > Cr-Commit-Position: refs/heads/master@{#340263} TBR=fgorski@chromium.org,jianli@chromium.org,johnme@chromium.org,thakis@chromium.org,avi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=486040 Committed: https://crrev.com/8abc01b225df94c4f1b614319ae786623f328ef5 Cr-Commit-Position: refs/heads/master@{#340268}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -367 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/push_messaging/push_messaging_browsertest.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_impl.h View 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_impl.cc View 6 chunks +23 lines, -82 lines 0 comments Download
M chrome/browser/services/gcm/fake_gcm_profile_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service.cc View 3 chunks +2 lines, -14 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/push_messaging/push_test.js View 1 chunk +0 lines, -10 lines 0 comments Download
M components/gcm_driver.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/gcm_driver/crypto/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D components/gcm_driver/crypto/gcm_encryption_provider.h View 1 chunk +0 lines, -65 lines 0 comments Download
D components/gcm_driver/crypto/gcm_encryption_provider.cc View 1 chunk +0 lines, -74 lines 0 comments Download
M components/gcm_driver/crypto/gcm_key_store.h View 2 chunks +2 lines, -6 lines 0 comments Download
M components/gcm_driver/crypto/gcm_key_store.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M components/gcm_driver/crypto/gcm_key_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/gcm_driver/fake_gcm_driver.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/gcm_driver/fake_gcm_driver.cc View 1 chunk +1 line, -8 lines 0 comments Download
M components/gcm_driver/gcm_driver.h View 4 chunks +1 line, -21 lines 0 comments Download
M components/gcm_driver/gcm_driver.cc View 3 chunks +3 lines, -15 lines 0 comments Download
M components/gcm_driver/gcm_driver_android.h View 1 chunk +1 line, -9 lines 0 comments Download
M components/gcm_driver/gcm_driver_android.cc View 1 chunk +1 line, -4 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/common/push_messaging_status.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Beverloo
Created Revert of Hook up the Push API with GCM's new ability to own encryption ...
5 years, 5 months ago (2015-07-24 13:15:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259613002/1
5 years, 5 months ago (2015-07-24 13:15:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-24 13:16:51 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 13:17:31 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8abc01b225df94c4f1b614319ae786623f328ef5
Cr-Commit-Position: refs/heads/master@{#340268}

Powered by Google App Engine
This is Rietveld 408576698