Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: tools/dom/templates/html/impl/impl_Element.darttemplate

Issue 12596004: Replaced Element.append with Node.appendChild (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/templates/html/impl/impl_Element.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_Element.darttemplate b/tools/dom/templates/html/impl/impl_Element.darttemplate
index 3556d5bbcbd5e8612decf3547069fd8032015208..4d70126c28c221c75d2fe4a264664b88042bbe35 100644
--- a/tools/dom/templates/html/impl/impl_Element.darttemplate
+++ b/tools/dom/templates/html/impl/impl_Element.darttemplate
@@ -133,7 +133,7 @@ class _ChildrenElementList implements List {
}
Element add(Element value) {
- _element.$dom_appendChild(value);
+ _element.append(value);
return value;
}
@@ -147,7 +147,7 @@ class _ChildrenElementList implements List {
}
for (Element element in iterable) {
- _element.$dom_appendChild(element);
+ _element.append(element);
}
}
@@ -764,13 +764,6 @@ $(ANNOTATIONS)abstract class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {
$dom_offsetHeight);
/**
- * Adds the specified element to after the last child of this element.
- */
- void append(Element e) {
- this.children.add(e);
- }
-
- /**
* Adds the specified text as a text node after the last child of this
* element.
*/
@@ -975,7 +968,7 @@ $if DART2JS
this.insertBefore(node, first);
break;
case 'beforeend':
- this.nodes.add(node);
+ this.append(node);
break;
case 'afterend':
this.parentNode.insertBefore(node, this.nextNode);
« no previous file with comments | « tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate ('k') | tools/dom/templates/html/impl/impl_Node.darttemplate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698