Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1259583003: PPC: Cross-script variables handling fixed. It was possible to write to read-only global variable. (Closed)

Created:
5 years, 4 months ago by MTBrandyberry
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Cross-script variables handling fixed. It was possible to write to read-only global variable. Port 156042f7f71effd101fbfb2ca1b5a2c3aec62079 R=ishell@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/ee70ad1be724fd5b513fef292e468ef7acae72f4 Cr-Commit-Position: refs/heads/master@{#29880}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/ppc/code-stubs-ppc.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 4 months ago (2015-07-27 15:03:13 UTC) #1
dstence
lgtm
5 years, 4 months ago (2015-07-27 17:16:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259583003/1
5 years, 4 months ago (2015-07-27 17:33:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-27 18:01:26 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 18:01:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee70ad1be724fd5b513fef292e468ef7acae72f4
Cr-Commit-Position: refs/heads/master@{#29880}

Powered by Google App Engine
This is Rietveld 408576698