Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 1259573006: Prevent GuestView from swapping process on cross-site navigations in --site-per-process. (Closed)

Created:
5 years, 5 months ago by lfg
Modified:
5 years, 4 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, jam, lazyboy, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent GuestView from swapping process on cross-site navigations in --site-per-process. BUG=330264 Committed: https://crrev.com/9fbf63023255c931d2903316dc5b645575015f36 Cr-Commit-Position: refs/heads/master@{#340470}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/browser/loader/cross_site_resource_handler.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
lfg
Hi Charlie, please take a look.
5 years, 5 months ago (2015-07-24 19:00:04 UTC) #2
Charlie Reis
In the CL description, s/to swap process/from swapping processes/. LGTM with nits. Is there a ...
5 years, 5 months ago (2015-07-24 19:20:32 UTC) #3
lfg
On 2015/07/24 19:20:32, Charlie Reis wrote: > In the CL description, s/to swap process/from swapping ...
5 years, 5 months ago (2015-07-24 22:05:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259573006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259573006/20001
5 years, 4 months ago (2015-07-27 14:51:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-27 15:41:50 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 15:43:22 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9fbf63023255c931d2903316dc5b645575015f36
Cr-Commit-Position: refs/heads/master@{#340470}

Powered by Google App Engine
This is Rietveld 408576698