Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: ui/views/cocoa/native_widget_mac_nswindow.mm

Issue 1259513002: [MacViews] Use ChromeCommandDispatcherDelegate to handle keyboard shortcuts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@commandexecute
Patch Set: Sync. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/cocoa/native_widget_mac_nswindow.mm
diff --git a/ui/views/cocoa/native_widget_mac_nswindow.mm b/ui/views/cocoa/native_widget_mac_nswindow.mm
index 63ee8235725af961948509b5f50a815c0e0c1964..f0a4b57f9ece70f1ad529f59df1d76c21e752def 100644
--- a/ui/views/cocoa/native_widget_mac_nswindow.mm
+++ b/ui/views/cocoa/native_widget_mac_nswindow.mm
@@ -56,6 +56,14 @@
return ![self viewsWidget]->widget_delegate()->ShouldShowWindowTitle();
}
+// Public methods.
tapted 2015/08/27 02:58:18 nit: should come before private methods (after ini
jackhou1 2015/08/27 22:37:48 Done.
+
+- (void)setCommandDispatcherDelegate:(id<CommandDispatcherDelegate>)delegate {
+ [commandDispatcher_ setDelegate:delegate];
+}
+
+// NSWindow overrides.
tapted 2015/08/27 02:58:18 I think technically _isTitleHidden is an NSWindow
jackhou1 2015/08/27 22:37:47 Done.
+
// Ignore [super canBecome{Key,Main}Window]. The default is NO for windows with
// NSBorderlessWindowMask, which is not the desired behavior.
// Note these can be called via -[NSWindow close] while the widget is being torn

Powered by Google App Engine
This is Rietveld 408576698