ui/views/widget/native_widget_mac.mm - Issue 1259513002: [MacViews] Use ChromeCommandDispatcherDelegate to handle keyboard shortcuts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/native_widget_mac.mm

Issue 1259513002: [MacViews] Use ChromeCommandDispatcherDelegate to handle keyboard shortcuts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@commandexecute

Patch Set: Address comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/widget/native_widget_mac.mm

diff --git a/ui/views/widget/native_widget_mac.mm b/ui/views/widget/native_widget_mac.mm

index 4f92b4066336979f361d9029beb3decc76f99e0b..da69d148c995f7fc84ad44bcc5eb1b9e19f9fdd8 100644

--- a/ui/views/widget/native_widget_mac.mm

+++ b/ui/views/widget/native_widget_mac.mm

@@ -569,7 +569,8 @@ void NativeWidgetMac::RepostNativeEvent(gfx::NativeEvent native_event) {

////////////////////////////////////////////////////////////////////////////////

// NativeWidgetMac, protected:

-NSWindow* NativeWidgetMac::CreateNSWindow(const Widget::InitParams& params) {

+NativeWidgetMacNSWindow* NativeWidgetMac::CreateNSWindow(

+ const Widget::InitParams& params) {

return [[[NativeWidgetMacNSWindow alloc]

initWithContentRect:ui::kWindowSizeDeterminedLater

styleMask:StyleMaskForParams(params)

« no previous file with comments | « ui/views/widget/native_widget_mac.h ('k') | ui/views/widget/native_widget_mac_unittest.mm » ('j') | no next file with comments »