chrome/chrome_browser_ui.gypi - Issue 1259513002: [MacViews] Use ChromeCommandDispatcherDelegate to handle keyboard shortcuts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 1259513002: [MacViews] Use ChromeCommandDispatcherDelegate to handle keyboard shortcuts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@commandexecute

Patch Set: Address comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/native_browser_frame_factory_mac.mm ('k') | ui/views/cocoa/native_widget_mac_nswindow.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser_ui.gypi

diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi

index 383359b727b34233d1cab4bcd7c3452abef6f9f5..d9b549136b545032bada0f6ec3cc019bb152dd45 100644

--- a/chrome/chrome_browser_ui.gypi

+++ b/chrome/chrome_browser_ui.gypi

@@ -894,8 +894,6 @@

'browser/ui/cocoa/bubble_view.mm',

'browser/ui/cocoa/chrome_browser_window.h',

'browser/ui/cocoa/chrome_browser_window.mm',

- 'browser/ui/cocoa/chrome_command_dispatcher_delegate.h',

- 'browser/ui/cocoa/chrome_command_dispatcher_delegate.mm',

'browser/ui/cocoa/chrome_event_processing_window.h',

'browser/ui/cocoa/chrome_event_processing_window.mm',

'browser/ui/cocoa/clickhold_button_cell.h',

@@ -1381,6 +1379,8 @@

'browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h',

'browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm',

'browser/ui/cocoa/certificate_viewer_mac.mm',

+ 'browser/ui/cocoa/chrome_command_dispatcher_delegate.h',

+ 'browser/ui/cocoa/chrome_command_dispatcher_delegate.mm',

'browser/ui/cocoa/color_chooser_mac.mm',

'browser/ui/cocoa/confirm_quit.h',

'browser/ui/cocoa/confirm_quit_panel_controller.h',

@@ -2178,7 +2178,7 @@

'browser/ui/views/frame/native_browser_frame_factory.cc',

'browser/ui/views/frame/native_browser_frame_factory.h',

'browser/ui/views/frame/native_browser_frame_factory_chromeos.cc',

- 'browser/ui/views/frame/native_browser_frame_factory_mac.cc',

+ 'browser/ui/views/frame/native_browser_frame_factory_mac.mm',

'browser/ui/views/frame/system_menu_insertion_delegate_win.cc',

'browser/ui/views/frame/system_menu_insertion_delegate_win.h',

'browser/ui/views/frame/system_menu_model_builder.cc',

« no previous file with comments | « chrome/browser/ui/views/frame/native_browser_frame_factory_mac.mm ('k') | ui/views/cocoa/native_widget_mac_nswindow.h » ('j') | no next file with comments »