chrome/browser/ui/views/apps/app_window_native_widget_mac.mm - Issue 1259513002: [MacViews] Use ChromeCommandDispatcherDelegate to handle keyboard shortcuts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_window_native_widget_mac.mm

Issue 1259513002: [MacViews] Use ChromeCommandDispatcherDelegate to handle keyboard shortcuts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@commandexecute

Patch Set: Address comments. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/apps/app_window_native_widget_mac.h ('k') | chrome/browser/ui/views/frame/browser_frame_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_window_native_widget_mac.mm

diff --git a/chrome/browser/ui/views/apps/app_window_native_widget_mac.mm b/chrome/browser/ui/views/apps/app_window_native_widget_mac.mm

index 1bab9b8373373bc19105d504b911f2a1fee03e52..ca79001e83c89887f725db972a7a2b6eca14f024 100644

--- a/chrome/browser/ui/views/apps/app_window_native_widget_mac.mm

+++ b/chrome/browser/ui/views/apps/app_window_native_widget_mac.mm

@@ -20,12 +20,13 @@ AppWindowNativeWidgetMac::AppWindowNativeWidgetMac(

AppWindowNativeWidgetMac::~AppWindowNativeWidgetMac() {

}

-NSWindow* AppWindowNativeWidgetMac::CreateNSWindow(

+NativeWidgetMacNSWindow* AppWindowNativeWidgetMac::CreateNSWindow(

const views::Widget::InitParams& params) {

// If the window has a native or colored frame, use the same NSWindow as

// NativeWidgetMac.

if (!native_app_window_->IsFrameless()) {

- NSWindow* ns_window = NativeWidgetMac::CreateNSWindow(params);

+ NativeWidgetMacNSWindow* ns_window =

+ NativeWidgetMac::CreateNSWindow(params);

if (native_app_window_->HasFrameColor()) {

[TitlebarBackgroundView

addToNSWindow:ns_window

« no previous file with comments | « chrome/browser/ui/views/apps/app_window_native_widget_mac.h ('k') | chrome/browser/ui/views/frame/browser_frame_mac.h » ('j') | no next file with comments »