chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.mm - Issue 1259513002: [MacViews] Use ChromeCommandDispatcherDelegate to handle keyboard shortcuts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.mm

Issue 1259513002: [MacViews] Use ChromeCommandDispatcherDelegate to handle keyboard shortcuts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@commandexecute

Patch Set: Address comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.mm

diff --git a/chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.mm b/chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.mm

index 3d0bf8fc024f1e74e9d3764a2ab182fcebea8a4a..d89c0c6b25b4e9fd3fa4df5d37e6c8ec8875d5dc 100644

--- a/chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.mm

+++ b/chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.mm

@@ -79,6 +79,8 @@ bool HandleExtraBrowserKeyboardShortcut(NSEvent* event, NSWindow* window) {

// redispatched event, [event window] gives the correct window.

if ([event window]) {

BrowserWindowController* controller = [[event window] windowController];

+ // |controller| is only set in Cocoa. In toolkit-views extension commands

+ // are handled elsewhere.

tapted 2015/08/28 05:48:14 elsewhere -> something more specific?

jackhou1 2015/09/01 06:51:05 Done.

if ([controller respondsToSelector:@selector(handledByExtensionCommand:

priority:)]) {

ui::AcceleratorManager::HandlerPriority priority =

« no previous file with comments | « no previous file | chrome/browser/ui/views/accelerator_table.cc » ('j') | no next file with comments »