Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3277)

Unified Diff: chrome/browser/metrics/plugin_metrics_provider.cc

Issue 1259493003: Treat PPAPI disconnect as a crash for plugin metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more realistic test Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/plugin_metrics_provider.cc
diff --git a/chrome/browser/metrics/plugin_metrics_provider.cc b/chrome/browser/metrics/plugin_metrics_provider.cc
index 136188d91b69fc280aca6b3444df607269732d49..e1ac7688141018a579a2c9f038e8160f13e3bfaf 100644
--- a/chrome/browser/metrics/plugin_metrics_provider.cc
+++ b/chrome/browser/metrics/plugin_metrics_provider.cc
@@ -366,6 +366,13 @@ void PluginMetricsProvider::BrowserChildProcessInstanceCreated(
RecordCurrentStateWithDelay(kRecordStateDelayMs);
}
+void PluginMetricsProvider::BrowserChildProcessHostDisconnected(
+ const content::ChildProcessData& data) {
+ // Treat a disconnect as a crash.
+ GetChildProcessStats(data).process_crashes++;
+ RecordCurrentStateWithDelay(kRecordStateDelayMs);
+}
+
bool PluginMetricsProvider::RecordCurrentStateWithDelay(int delay_sec) {
if (weak_ptr_factory_.HasWeakPtrs())
return false;
« no previous file with comments | « chrome/browser/metrics/plugin_metrics_provider.h ('k') | chrome/browser/metrics/plugin_metrics_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698