Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1259473004: Remove redundant call to closeMediaSource() in userCancelledLoad() (Closed)

Created:
5 years, 4 months ago by Srirama
Modified:
5 years, 3 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, nessy, mlamouri+watch-blink_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove redundant call to closeMediaSource() in userCancelledLoad() MediaSource is getting closed in clearMediaPlayer() and again we are calling closeMediaSource() which is redundant. Though there is an early return in closeMediaSource(), still the call is redundant. Committed: https://crrev.com/ccf0caa5278ac1c7e1d18cac66210ad42b436949 git-svn-id: svn://svn.chromium.org/blink/trunk@199500 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Srirama
PTAL.
5 years, 4 months ago (2015-07-27 07:56:16 UTC) #2
philipj_slow
lgtm
5 years, 4 months ago (2015-07-27 08:45:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259473004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259473004/1
5 years, 4 months ago (2015-07-27 08:45:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=199500
5 years, 4 months ago (2015-07-27 08:47:29 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:48:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ccf0caa5278ac1c7e1d18cac66210ad42b436949

Powered by Google App Engine
This is Rietveld 408576698