Add BoolFlag for rawdatastore.

Add Toggle for rawdatastore.

This will be used to control cacheability for entities, and allows setting a
default value in the tag without ambiguity (since the 'zero-value' for bools is
false, a simple bool wouldn't provide a way to override defaulted-true field).

R=dnj@google.com, vadimsh@chromium.org, dnj@chromium.org, estaab@chromium.org
BUG=

Committed: https://github.com/luci/gae/commit/92ee98fa28f06f5bdb297d6974ca085e566effff

[dnj (Google), 2015-07-24 16:11:37]

dnj@google.com changed reviewers:
+ dnj@google.com

[dnj (Google), 2015-07-24 16:11:37]

lgtm w/ nit

https://codereview.chromium.org/1259463002/diff/1/service/rawdatastore/types.go
File service/rawdatastore/types.go (right):

https://codereview.chromium.org/1259463002/diff/1/service/rawdatastore/types....
service/rawdatastore/types.go:61: return "True"
not: Perhaps lowercase "true"/"false", as that's what it is being parsed from.

[iannucci, 2015-07-24 16:15:06]

Hm... Generally the string should represent the "repr" of the type, no?

On Fri, Jul 24, 2015, 09:11  <dnj@google.com> wrote:

> lgtm w/ nit
>
>
>
>
https://codereview.chromium.org/1259463002/diff/1/service/rawdatastore/types.go
> File service/rawdatastore/types.go (right):
>
>
>
https://codereview.chromium.org/1259463002/diff/1/service/rawdatastore/types....
> service/rawdatastore/types.go:61
>
<https://codereview.chromium.org/1259463002/diff/1/service/rawdatastore/types....>:
> return "True"
> not: Perhaps lowercase "true"/"false", as that's what it is being parsed
> from.
>
> https://codereview.chromium.org/1259463002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dnj (Google), 2015-07-24 16:17:34]

On 2015/07/24 16:15:06, iannucci wrote:
> Hm... Generally the string should represent the "repr" of the type, no?

Probably, but here we have: "true" string parsed to True type, which returns
"True" string. I suppose this depends on whether "String()" is user-facing or
go-facing. I assume the former and use https://golang.org/pkg/fmt/#GoStringer
for the latter.

[Vadim Sh., 2015-07-24 18:53:00]

https://codereview.chromium.org/1259463002/diff/20001/service/rawdatastore/pr...
File service/rawdatastore/properties.go (right):

https://codereview.chromium.org/1259463002/diff/20001/service/rawdatastore/pr...
service/rawdatastore/properties.go:360: //     TFlag BoolFlag
`gae:"$flag1,true"`  // defaults to true
update to Toggle & on\off

https://codereview.chromium.org/1259463002/diff/20001/service/rawdatastore/ty...
File service/rawdatastore/types.go (right):

https://codereview.chromium.org/1259463002/diff/20001/service/rawdatastore/ty...
service/rawdatastore/types.go:46: // to control boolean flags for metadata in a
non-ambiguous way.
what is Auto? It IS ambiguous, at leas from reading this comment.

[iannucci, 2015-07-24 19:06:15]

If you set a Toggle field, you MUST include a default, and it MUST be true
or false. Auto is only available on the field itself, and it means "use the
default"

On Fri, Jul 24, 2015, 11:53  <vadimsh@chromium.org> wrote:

>
>
>
https://codereview.chromium.org/1259463002/diff/20001/service/rawdatastore/pr...
> File service/rawdatastore/properties.go (right):
>
>
>
https://codereview.chromium.org/1259463002/diff/20001/service/rawdatastore/pr...
> service/rawdatastore/properties.go:360
>
<https://codereview.chromium.org/1259463002/diff/20001/service/rawdatastore/pr...>:
> //     TFlag BoolFlag
> `gae:"$flag1,true"`  // defaults to true
> update to Toggle & on\off
>
>
>
https://codereview.chromium.org/1259463002/diff/20001/service/rawdatastore/ty...
> File service/rawdatastore/types.go (right):
>
>
>
https://codereview.chromium.org/1259463002/diff/20001/service/rawdatastore/ty...
> service/rawdatastore/types.go:46
>
<https://codereview.chromium.org/1259463002/diff/20001/service/rawdatastore/ty...>:
> // to control boolean flags for
> metadata in a non-ambiguous way.
> what is Auto? It IS ambiguous, at leas from reading this comment.
>
> https://codereview.chromium.org/1259463002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[iannucci, 2015-07-24 20:58:10]

PTAL

https://chromiumcodereview.appspot.com/1259463002/diff/20001/service/rawdatas...
File service/rawdatastore/properties.go (right):

https://chromiumcodereview.appspot.com/1259463002/diff/20001/service/rawdatas...
service/rawdatastore/properties.go:360: //     TFlag BoolFlag
`gae:"$flag1,true"`  // defaults to true
On 2015/07/24 18:53:00, Vadim Sh. wrote:
> update to Toggle & on\off

Done.

https://chromiumcodereview.appspot.com/1259463002/diff/20001/service/rawdatas...
File service/rawdatastore/types.go (right):

https://chromiumcodereview.appspot.com/1259463002/diff/20001/service/rawdatas...
service/rawdatastore/types.go:46: // to control boolean flags for metadata in a
non-ambiguous way.
On 2015/07/24 18:53:00, Vadim Sh. wrote:
> what is Auto? It IS ambiguous, at leas from reading this comment.

Auto means 'use the default in the field tag'. I've updated the docs on GetMeta,
added a test, etc. Is this clearer now?

[Vadim Sh., 2015-07-24 20:59:54]

lgtm

[iannucci, 2015-07-24 21:02:17]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2015-07-24 21:02:18]

The patchset sent to the CQ was uploaded after l-g-t-m from dnj@google.com
Link to the patchset: https://chromiumcodereview.appspot.com/1259463002/#ps60001
(title: "improve error")

[commit-bot: I haz the power, 2015-07-24 21:05:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-24 21:05:02]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[Vadim Sh., 2015-07-24 21:07:32]

On 2015/07/24 21:05:02, commit-bot: I haz the power wrote:
> Commit queue rejected this change because it did not recognize the base URL.
> Please commit your change manually.

lol

[iannucci, 2015-07-24 21:10:02]

Oh. Rite.

On Fri, Jul 24, 2015 at 2:07 PM <vadimsh@chromium.org> wrote:

> On 2015/07/24 21:05:02, commit-bot: I haz the power wrote:
> > Commit queue rejected this change because it did not recognize the base
> > URL.
> > Please commit your change manually.
>
> lol
>
> https://codereview.chromium.org/1259463002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[iannucci, 2015-07-24 21:10:05]

Committed patchset #4 (id:60001) manually as
92ee98fa28f06f5bdb297d6974ca085e566effff (presubmit successful).