Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 1259413003: Revert of Devtools UI: Update inspect element node description label UI (Closed)

Created:
5 years, 4 months ago by pfeldman
Modified:
5 years, 4 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Devtools UI: Update inspect element node description label UI (patchset #6 id:100001 of https://codereview.chromium.org/1255573004/) Reason for revert: Tried it, regresses my experience, will post more into the bug. Original issue's description: > Devtools UI: Update inspect element node description label UI > > This change updates the node description label to match updated tooltip > UI. These labels have the following characteristics: > - Default to above the anchor element > - Centered above the anchor element > - Clamped to the visible viewport (no change) > - Non monospace font to improve text readibility > - Removal of "px" in dimensions > > BUG=513066 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199732 TBR=dgozman@chromium.org,maxwalker@chromium.org,paulirish@chromium.org,sergeyv@chromium.org,samli@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=513066 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199759

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -132 lines) Patch
M Source/core/inspector/InspectorOverlayPage.html View 7 chunks +83 lines, -132 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pfeldman
Created Revert of Devtools UI: Update inspect element node description label UI
5 years, 4 months ago (2015-07-30 21:53:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259413003/1
5 years, 4 months ago (2015-07-30 21:54:15 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 21:54:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199759

Powered by Google App Engine
This is Rietveld 408576698