Issue 12594038: [Android] Shorten long suite names in test reporting step.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12594038: [Android] Shorten long suite names in test reporting step. (Closed)

Created:
7 years, 9 months ago by frankf

Modified:
7 years, 9 months ago

Reviewers:
craigdh

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Shorten long suite names in test reporting step. NOTRY=True BUG=

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	build/android/pylib/utils/report_results.py	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/12594038/1

7 years, 9 months ago (2013-03-27 21:13:51 UTC) #3

commit-bot: I haz the power

7 years, 9 months ago (2013-03-27 21:13:53 UTC) #4

Failed to apply patch for build/android/pylib/utils/report_results.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file build/android/pylib/utils/report_results.py
  Hunk #1 FAILED at 31.
  1 out of 1 hunk FAILED -- saving rejects to file
build/android/pylib/utils/report_results.py.rej

Patch:       build/android/pylib/utils/report_results.py
Index: build/android/pylib/utils/report_results.py
diff --git a/build/android/pylib/utils/report_results.py
b/build/android/pylib/utils/report_results.py
index
9ac05ebd4a7ced955a4b40f9815139ececbb2560..9ac2620b361bd40bf748cd14e8010de9ac0d0d6e
100644
--- a/build/android/pylib/utils/report_results.py
+++ b/build/android/pylib/utils/report_results.py
@@ -31,7 +31,9 @@ def _LogToFile(results, test_type, test_suite, build_type):
 
   logging.info('Writing results to %s.' % full_file_name)
   with open(full_file_name, 'a') as log_file:
-    print >> log_file, '%s%s' % (test_suite.ljust(30), results.GetShortForm())
+    shortened_suite_name = test_suite[:25] + (test_suite[25:] and '...')
+    print >> log_file, '%s%s' % (shortened_suite_name.ljust(30),
+                                 results.GetShortForm())
 
 
 def _LogToFlakinessDashboard(results, test_type, test_package,

Expand Messages | Collapse Messages