Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: tests/barebones/nacl.scons

Issue 12594036: Add a scons pnacl finalize step for pnacl_generate_pexe tests. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Use StripSuffix Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « site_scons/site_tools/naclsdk.py ('k') | tests/custom_desc/nacl.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/barebones/nacl.scons
diff --git a/tests/barebones/nacl.scons b/tests/barebones/nacl.scons
index eede92149149e9add4e88e4643d6ffab100e76e9..062add2299128efb893354d852534fa370775681 100644
--- a/tests/barebones/nacl.scons
+++ b/tests/barebones/nacl.scons
@@ -22,6 +22,16 @@ env.Replace(LIBS=[],
if env.Bit('build_arm'):
env.Append(CPPDEFINES='SMALL_REGS_TEST')
+# The barebones_reloc test need symbols preserved, since it provides
+# a stub function for something that normally comes from the system libraries.
+# TODO(jvoung): That can be fixed by removing -nostdlib from TRANSLATEFLAGS.
+# Then the translator will get the required functions from system libs.
+# However, removing -nostdlib from TRANSLATEFLAGS will break due to:
+# https://code.google.com/p/nativeclient/issues/detail?id=3069
+if env.Bit('bitcode'):
+ env.SetBits('nonstable_bitcode')
+if env.Bit('skip_nonstable_bitcode'):
+ Return()
# NOTE: the x86 linker wants _start() to be the very first function
FAKE_STARTUP = env.ComponentObject('fake_startup', 'fake_startup.c')
« no previous file with comments | « site_scons/site_tools/naclsdk.py ('k') | tests/custom_desc/nacl.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698