Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: tests/barebones/nacl.scons

Issue 12594036: Add a scons pnacl finalize step for pnacl_generate_pexe tests. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Roll revs Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/barebones/nacl.scons
diff --git a/tests/barebones/nacl.scons b/tests/barebones/nacl.scons
index eede92149149e9add4e88e4643d6ffab100e76e9..d4e8bfa62b0d8e6a006abe689524e4ec14359ee4 100644
--- a/tests/barebones/nacl.scons
+++ b/tests/barebones/nacl.scons
@@ -22,6 +22,12 @@ env.Replace(LIBS=[],
if env.Bit('build_arm'):
env.Append(CPPDEFINES='SMALL_REGS_TEST')
+# The barebones_reloc test need symbols preserved, since it provides
+# a stub function for something that normally comes from the libraries.
Mark Seaborn 2013/03/28 01:31:34 What stub function does barebones_reloc provide th
jvoung - send to chromium... 2013/03/28 15:50:29 barebones_reloc.c stores to a few tls variables.
Mark Seaborn 2013/03/28 16:44:33 Do you get a link error here? I'm not sure why st
jvoung (off chromium) 2013/03/28 17:54:50 Yes it's a link error, trying to find __nacl_read_
+if env.Bit('bitcode'):
+ env.SetBits('nonstable_bitcode')
+if env.Bit('skip_nonstable_bitcode'):
+ Return()
# NOTE: the x86 linker wants _start() to be the very first function
FAKE_STARTUP = env.ComponentObject('fake_startup', 'fake_startup.c')
« SConstruct ('K') | « site_scons/site_tools/naclsdk.py ('k') | tests/gdb/nacl.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698