Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4227)

Unified Diff: chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller_browsertest.mm

Issue 12594015: Alternate NTP Mac: Push down overlay in presentation mode (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller_browsertest.mm
diff --git a/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller_browsertest.mm b/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller_browsertest.mm
index 8a2aac1e68b5aadae4adc1bf36a4290fc737e0e9..a81d2e42837c58d64d0b1ff1f20a422d7387bea8 100644
--- a/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller_browsertest.mm
+++ b/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller_browsertest.mm
@@ -169,3 +169,23 @@ IN_PROC_BROWSER_TEST_F(OverlayableContentsControllerTest, HeightChangeNoHide) {
instant_overlay_model_.SetOverlayState(mode, 11, INSTANT_SIZE_PERCENT);
EXPECT_EQ(1, visibility_changed_count_);
}
+
+IN_PROC_BROWSER_TEST_F(OverlayableContentsControllerTest, OverlayOffset) {
+ chrome::search::Mode mode;
+ mode.mode = chrome::search::Mode::MODE_NTP;
+ CGFloat expected_height = 10;
+ InstantSizeUnits units = INSTANT_SIZE_PIXELS;
+ instant_overlay_model_.SetOverlayState(mode, expected_height, units);
+
+ CGFloat separator_height = [OverlayTopSeparatorView preferredHeight];
+ NSView* overlay_view = web_contents_->GetView()->GetNativeView();
+ EXPECT_EQ(separator_height,
+ NSMaxY([[overlay_view superview] frame]) -
+ NSMaxY([overlay_view frame]));
+
+ CGFloat offset = 30;
+ [controller_ setOverlayContentsOffset:offset];
+ EXPECT_EQ(separator_height + offset,
+ NSMaxY([[overlay_view superview] frame]) -
+ NSMaxY([overlay_view frame]));
+}

Powered by Google App Engine
This is Rietveld 408576698