Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Unified Diff: remoting/host/desktop_session_agent.cc

Issue 12594009: Converted LocalInputMonitor into a SessionController instance. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Posting ClientSessionControl tasks directly since we have a weak point now. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/desktop_session_agent.cc
diff --git a/remoting/host/desktop_session_agent.cc b/remoting/host/desktop_session_agent.cc
index ab29a7d0e682b808ac270eb945d1f5b89b415573..2ff2d9ea5057c201cb8b2bfcc095e4908bd0a767 100644
--- a/remoting/host/desktop_session_agent.cc
+++ b/remoting/host/desktop_session_agent.cc
@@ -17,7 +17,6 @@
#include "remoting/host/desktop_environment.h"
#include "remoting/host/disconnect_window.h"
#include "remoting/host/event_executor.h"
-#include "remoting/host/local_input_monitor.h"
#include "remoting/host/remote_input_filter.h"
#include "remoting/host/screen_controls.h"
#include "remoting/host/screen_resolution.h"
@@ -71,7 +70,6 @@ DesktopSessionAgent::~DesktopSessionAgent() {
DCHECK(!audio_capturer_);
DCHECK(!desktop_environment_);
DCHECK(!disconnect_window_);
- DCHECK(!local_input_monitor_);
DCHECK(!network_channel_);
DCHECK(!screen_controls_);
DCHECK(!video_capturer_);
@@ -185,7 +183,7 @@ void DesktopSessionAgent::OnLocalMouseMoved(const SkIPoint& new_pos) {
void DesktopSessionAgent::SetDisableInputs(bool disable_inputs) {
DCHECK(caller_task_runner()->BelongsToCurrentThread());
- // Do not expact this method to be called because it is only used by It2Me.
+ // Do not expect this method to be called because it is only used by It2Me.
NOTIMPLEMENTED();
}
@@ -197,7 +195,6 @@ void DesktopSessionAgent::OnStartSessionAgent(
DCHECK(!audio_capturer_);
DCHECK(!desktop_environment_);
DCHECK(!disconnect_window_);
- DCHECK(!local_input_monitor_);
DCHECK(!screen_controls_);
DCHECK(!video_capturer_);
@@ -231,19 +228,11 @@ void DesktopSessionAgent::OnStartSessionAgent(
event_executor_->Start(clipboard_stub.Pass());
// Create the disconnect window.
- base::Closure disconnect_session =
- base::Bind(&DesktopSessionAgent::DisconnectSession, this);
disconnect_window_ = DisconnectWindow::Create(&ui_strings_);
disconnect_window_->Show(
- disconnect_session,
+ base::Bind(&DesktopSessionAgent::DisconnectSession, this),
authenticated_jid.substr(0, authenticated_jid.find('/')));
- // Start monitoring local input.
- local_input_monitor_ = LocalInputMonitor::Create(caller_task_runner_,
- input_task_runner_,
- caller_task_runner_);
- local_input_monitor_->Start(this, disconnect_session);
-
// Start the audio capturer.
if (delegate_->desktop_environment_factory().SupportsAudioCapture()) {
audio_capturer_ = desktop_environment_->CreateAudioCapturer();
@@ -346,19 +335,15 @@ void DesktopSessionAgent::Stop() {
control_factory_.InvalidateWeakPtrs();
client_jid_.clear();
- // Stop monitoring to local input.
- local_input_monitor_->Stop();
- local_input_monitor_.reset();
-
remote_input_filter_.reset();
// Ensure that any pressed keys or buttons are released.
input_tracker_->ReleaseAll();
input_tracker_.reset();
+ desktop_environment_.reset();
event_executor_.reset();
screen_controls_.reset();
- desktop_environment_.reset();
// Stop the audio capturer.
audio_capture_task_runner()->PostTask(

Powered by Google App Engine
This is Rietveld 408576698