Converted LocalInputMonitor into a SessionController instance.

remoting/host/session_controller.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_SESSION_CONTROLLER_H_
 #define REMOTING_HOST_SESSION_CONTROLLER_H_
 
 #include "base/basictypes.h"
-#include "remoting/host/mouse_move_observer.h"
 #include "third_party/skia/include/core/SkPoint.h"
 #include "third_party/skia/include/core/SkSize.h"
 
 namespace remoting {
 
 class ScreenResolution;
 
 class SessionController {

[Sergey Ulanov, 2013/03/20 06:31:06]

This interface is used for two unrelated features (1) monitoring mouse moves and
(2) updating screen resolution. LocalInputMonitor doesn't care about resolution,
while ResizingHostObserver doesn't touch delegate. So I wonder why we need this
interface at all? Can Delegate be moved to LocalInputMonitor?

Or is the intent here to provide a generic interface for optional features that
may or may not be enabled? In that case it may be better to name it something
like SessionExtension.

Also pleas add comments for this interface.

[alexeypa (please no reviews), 2013/03/20 17:05:29]

It is indeed used for two unrelated purposes yet I think splitting it into two
separate interfaces will introduce more noise, but little or not gain:

- DesktopEnvironment will get another CreateXxx() method meanisng that it will
be added to all 4 variations of DesktopEnvironment and 4 mocked
DesktopEnvironment's are well.
- ClientSession and DesktopSessoinAgent will get another pointer with life-time
identical to session_controller_.

So I think mixing the two here is less evil.
No. This delegate will be used by the disconnect and continue windows as well.
I picked "SessionController" implying that objects implementing it control the
client session in one of two ways:

- They invoke SessionController::Delegate methods directly telling session what
to do.
- They modify the underlying desktop environment in some way affecting the
client session (resolution change).
Done.

I also added PauseSession() to SessionController::Delegate that will be used by
the continue window code.

  public:
-  // TODO(alexeypa): remove MouseMoveObserver entirely and move
-  // OnLocalMouseMoved() method to SessionController::Delegate.
-  // See http://crbug.com/104544.
-  class Delegate : public MouseMoveObserver {
+  class Delegate {
    public:
     virtual ~Delegate() {}
 
     // Disconnects the client session, tears down transport resources and stops
     // scheduler components.
     virtual void DisconnectSession() = 0;
 
     // Called when local mouse movement is detected.
     virtual void OnLocalMouseMoved(const SkIPoint& position) = 0;
   };
 
   virtual ~SessionController() {}
 
   // Attempts to set new screen resolution in the session.
   virtual void SetScreenResolution(const ScreenResolution& resolution) = 0;
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_SESSION_CONTROLLER_H_