Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: content/common/discardable_shared_memory_heap.h

Issue 1259333003: [tracing] Add SkResourceCache as suballocation to avoid double counting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@skia_v1
Patch Set: Fixing comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/discardable_shared_memory_heap.h
diff --git a/content/common/discardable_shared_memory_heap.h b/content/common/discardable_shared_memory_heap.h
index 7ded677c3cc75630b61181c16a4b20258943550e..11d1cc7d351e13bd5cacb4d2959ef0ac466f4222 100644
--- a/content/common/discardable_shared_memory_heap.h
+++ b/content/common/discardable_shared_memory_heap.h
@@ -88,6 +88,11 @@ class CONTENT_EXPORT DiscardableSharedMemoryHeap {
// Dumps memory statistics for chrome://tracing.
bool OnMemoryDump(base::trace_event::ProcessMemoryDump* pmd);
+ // Creates a common dump for all sub-allocated objects from discardable
+ // memory.
+ static void CreateAllocatedObjectsDump(
reveman 2015/07/30 16:00:59 I think this should be moved to the allocator impl
ssid 2015/07/30 20:05:15 I think it is needed in both implementations, so b
+ base::trace_event::ProcessMemoryDump* pmd);
reveman 2015/07/29 18:32:11 why do we want a common dump? Would it not be more
ssid 2015/07/29 19:36:22 Replied for the other comment.
+
// Returns a unique identifier for a given tuple of (process id, segment id)
// that can be used to match memory dumps across different processes.
static base::trace_event::MemoryAllocatorDumpGuid GetSegmentGUIDForTracing(

Powered by Google App Engine
This is Rietveld 408576698