content/common/discardable_shared_memory_heap.h - Issue 1259333003: [tracing] Add SkResourceCache as suballocation to avoid double counting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/discardable_shared_memory_heap.h

Issue 1259333003: [tracing] Add SkResourceCache as suballocation to avoid double counting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@skia_v1

Patch Set: addresssing comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/memory/discardable_shared_memory.cc ('k') | content/common/discardable_shared_memory_heap.cc » ('j') | content/common/discardable_shared_memory_heap.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/discardable_shared_memory_heap.h

diff --git a/content/common/discardable_shared_memory_heap.h b/content/common/discardable_shared_memory_heap.h

index 7ded677c3cc75630b61181c16a4b20258943550e..e8f48546cdda8f1da2f9687b19c2efeed1cb71fc 100644

--- a/content/common/discardable_shared_memory_heap.h

+++ b/content/common/discardable_shared_memory_heap.h

@@ -88,6 +88,11 @@ class CONTENT_EXPORT DiscardableSharedMemoryHeap {

// Dumps memory statistics for chrome://tracing.

bool OnMemoryDump(base::trace_event::ProcessMemoryDump* pmd);

+ // Creates a common dump for all the sub-allocated objects from discardable

petrcermak 2015/07/29 17:04:07 nit: I don't think there should be "the" here

ssid 2015/07/29 17:08:37 Done.

+ // memory.

+ static void CreateAllocatedObjectsDump(

+ base::trace_event::ProcessMemoryDump* pmd);

// Returns a unique identifier for a given tuple of (process id, segment id)

// that can be used to match memory dumps across different processes.

static base::trace_event::MemoryAllocatorDumpGuid GetSegmentGUIDForTracing(