Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: base/memory/discardable_shared_memory.h

Issue 1259333003: [tracing] Add SkResourceCache as suballocation to avoid double counting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@skia_v1
Patch Set: Nits. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/memory/discardable_shared_memory.h
diff --git a/base/memory/discardable_shared_memory.h b/base/memory/discardable_shared_memory.h
index 74bbe8e95f427ba347d696e6c6e9c408e166e167..459deb8ed354ddd257aff2f64062ce0a18e60ed4 100644
--- a/base/memory/discardable_shared_memory.h
+++ b/base/memory/discardable_shared_memory.h
@@ -29,6 +29,13 @@ namespace base {
// access to an instance of this class.
class BASE_EXPORT DiscardableSharedMemory {
public:
+ // Used by other allocators to expess sub-allocation from discardable memory
+ // heap for tracing. To expess any suballocation, the dump providers need to
+ // create a sub-allocation edge from this node.
+ // Eg. : ProcessMemoryDump::AddSuballocation(skia_dump_guid,
petrcermak 2015/07/29 16:38:59 nit: There should be a dot after "E" and no space
ssid 2015/07/29 16:57:37 Done.
+ // kDiscardableSegmentsDumpName);
petrcermak 2015/07/29 16:38:59 How is this related to the constant??? Shouldn't i
ssid 2015/07/29 16:57:37 Done.
+ static const char kAllocatedObjectsDumpName[];
+
enum LockResult { SUCCESS, PURGED, FAILED };
DiscardableSharedMemory();
« no previous file with comments | « no previous file | base/memory/discardable_shared_memory.cc » ('j') | content/common/discardable_shared_memory_heap.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698