Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1259303003: Removed GrFragmentProcessor::fWillUseInputColor (Closed)

Created:
5 years, 4 months ago by wangyix
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Removed GrFragmentProcessor::fWillUseInputColor TBR=bsalomon@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/570e7a34dab7800ccb1cfea03762367e24687b71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M include/gpu/GrFragmentProcessor.h View 4 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
wangyix
5 years, 4 months ago (2015-07-28 18:10:35 UTC) #2
joshualitt
On 2015/07/28 18:10:35, wangyix wrote: lgtm
5 years, 4 months ago (2015-07-28 18:33:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259303003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259303003/1
5 years, 4 months ago (2015-07-28 18:38:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/1378)
5 years, 4 months ago (2015-07-28 18:39:52 UTC) #7
wangyix
5 years, 4 months ago (2015-07-28 18:43:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259303003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259303003/1
5 years, 4 months ago (2015-07-28 18:47:11 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/570e7a34dab7800ccb1cfea03762367e24687b71
5 years, 4 months ago (2015-07-28 18:47:47 UTC) #12
tomhudson
5 years, 4 months ago (2015-08-14 14:47:38 UTC) #13
Message was sent while issue was closed.
For similar patches in the future, if there isn't a skbug in the BUG= line,
please add some motivation to the CL description.

Powered by Google App Engine
This is Rietveld 408576698