Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 12593014: Use internal memcpy when initializing code objects. (Closed)

Created:
7 years, 9 months ago by Michael Starzinger
Modified:
7 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Use internal memcpy when initializing code objects. R=jkummerow@chromium.org BUG=chromium:196330 Committed: http://code.google.com/p/v8/source/detail?r=14011

Patch Set 1 #

Patch Set 2 : Addressed Jakob Kummerow's offline comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M src/objects.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/v8utils.h View 1 2 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
We are vulcanizing our own rubber now.
7 years, 9 months ago (2013-03-20 16:40:50 UTC) #1
Jakob Kummerow
lgtm
7 years, 9 months ago (2013-03-20 16:47:01 UTC) #2
Michael Starzinger
7 years, 9 months ago (2013-03-20 16:53:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r14011 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698