Instant: Possible fix for crash.

chrome/browser/instant/instant_controller.cc

Index: chrome/browser/instant/instant_controller.cc
diff --git a/chrome/browser/instant/instant_controller.cc b/chrome/browser/instant/instant_controller.cc
index 2ac58173b02f73b30e5d0ca40d73b957d4349d7b..924688cd55c07bed903e89b8815dbc50decca666 100644
--- a/chrome/browser/instant/instant_controller.cc
+++ b/chrome/browser/instant/instant_controller.cc
@@ -631,9 +631,10 @@ bool InstantController::CommitIfPossible(InstantCommitType type) {
     if (type == INSTANT_COMMIT_PRESSED_ENTER &&
         (last_match_was_search_ ||
          last_suggestion_.behavior == INSTANT_COMPLETE_NEVER)) {
-      EnsureSearchTermsAreSet(instant_tab_->contents(), last_omnibox_text_);
+      last_suggestion_.text.clear();

[Jered, 2013/03/17 17:43:38]

Why do this?

[sreeram, 2013/03/17 17:53:27]

Line 636 calls Focus() on the web contents. I assumed this might lead to
OmniboxLostFocus(), which will try to "commit" the suggested text (gray text),
since all of the conditions in that 'if' statement will be true.

Incidentally, this also fixes http://crbug.com/196811.

All this is in theory. I haven't actually duplicated the crash, or verified that
this actually fixes anything. We'll know soon.

       instant_tab_->Submit(last_omnibox_text_);
       instant_tab_->contents()->GetView()->Focus();
+      EnsureSearchTermsAreSet(instant_tab_->contents(), last_omnibox_text_);
       return true;
     }
     return false;