editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java - Issue 12593009: Don't cast to NodeElement where not needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java

Issue 12593009: Don't cast to NodeElement where not needed. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Update status file. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java ('k') | editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/SemanticHighlightings.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java

diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java

index 825a1e836c1e8ce9c98146f872b657d790154cd5..c57fc2cc8b4c97d8cc3811b76366be3fd3f91af0 100644

--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java

+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java

@@ -36,7 +36,6 @@ import com.google.dart.compiler.resolver.ElementKind;

import com.google.dart.compiler.resolver.FieldElement;

import com.google.dart.compiler.resolver.LibraryElement;

import com.google.dart.compiler.resolver.MethodElement;

-import com.google.dart.compiler.resolver.NodeElement;

import com.google.dart.compiler.resolver.VariableElement;

import com.google.dart.tools.core.DartCore;

import com.google.dart.tools.core.internal.util.SourceRangeUtils;

@@ -508,7 +507,7 @@ public class DartElementLocator extends ASTVisitor<Void> {

int end = start + length;

if (start <= startOffset && endOffset <= end) {

wordRegion = new Region(start, length);

- NodeElement invocationElement = node.getElement();

+ Element invocationElement = node.getElement();

if (invocationElement != null && node.getTarget() != null

&& node.getTarget().getElement() != invocationElement) {

findElementFor(invocationElement);