Add a user pref in Settings to disable all GPU features.

Add a user pref in Settings to disable all GPU features.

BUG=173130
TEST=about:settings
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187666

[Zhenyao Mo, 2013-03-08 02:09:07]

cpu: chrome/app
jhawkins: options related
sky: chrome/test
joi: content/public
apatrick: gpu related
thestig: other chrome/browser changes

Please review.

[Jói, 2013-03-08 02:14:37]

LGTM for content/public

[sky, 2013-03-08 15:40:44]

chrome/test LGTM : feel free to TBR these sort of changes.

[cpu_(ooo_6.6-7.5), 2013-03-08 18:25:57]

grd files don't have owners anymore afaik.

[Lei Zhang, 2013-03-08 23:29:10]

https://codereview.chromium.org/12593005/diff/1/chrome/browser/gpu/gpu_mode_m...
File chrome/browser/gpu/gpu_mode_manager.cc (right):

https://codereview.chromium.org/12593005/diff/1/chrome/browser/gpu/gpu_mode_m...
chrome/browser/gpu/gpu_mode_manager.cc:21: CHECK(g_browser_process != NULL);
Probably don't need this. If |g_browser_process| is NULL, you'll crash on the
next line, you'll know what happened.

https://codereview.chromium.org/12593005/diff/1/chrome/browser/gpu/gpu_mode_m...
chrome/browser/gpu/gpu_mode_manager.cc:24: pref_registrar_.Add(
Do you need this when OnGpuModeEnabledPrefChanged doesn't do anything? If you do
need it, can you use DoNothing() from base/bind_helpers.h instead?

https://codereview.chromium.org/12593005/diff/1/chrome/browser/gpu/gpu_mode_m...
File chrome/browser/gpu/gpu_mode_manager.h (right):

https://codereview.chromium.org/12593005/diff/1/chrome/browser/gpu/gpu_mode_m...
chrome/browser/gpu/gpu_mode_manager.h:8: #include <string>
not needed?

https://codereview.chromium.org/12593005/diff/1/chrome/browser/gpu/gpu_mode_m...
chrome/browser/gpu/gpu_mode_manager.h:10: #include "base/compiler_specific.h"
You just need basictypes.h here, I think.

https://codereview.chromium.org/12593005/diff/1/chrome/browser/gpu/gpu_mode_m...
chrome/browser/gpu/gpu_mode_manager.h:20: virtual ~GpuModeManager();
virtual not needed?

[Zhenyao Mo, 2013-03-09 00:15:45]

thestig: revised, please have another look.

https://codereview.chromium.org/12593005/diff/1/chrome/browser/gpu/gpu_mode_m...
File chrome/browser/gpu/gpu_mode_manager.cc (right):

https://codereview.chromium.org/12593005/diff/1/chrome/browser/gpu/gpu_mode_m...
chrome/browser/gpu/gpu_mode_manager.cc:21: CHECK(g_browser_process != NULL);
On 2013/03/08 23:29:10, Lei Zhang wrote:
> Probably don't need this. If |g_browser_process| is NULL, you'll crash on the
> next line, you'll know what happened.

Done.

https://codereview.chromium.org/12593005/diff/1/chrome/browser/gpu/gpu_mode_m...
chrome/browser/gpu/gpu_mode_manager.cc:24: pref_registrar_.Add(
On 2013/03/08 23:29:10, Lei Zhang wrote:
> Do you need this when OnGpuModeEnabledPrefChanged doesn't do anything? If you
do
> need it, can you use DoNothing() from base/bind_helpers.h instead?

I do need this, otherwise Settings page won't load, claiming lacking of a
handler for the pref.  Change to DoNothing().

https://codereview.chromium.org/12593005/diff/1/chrome/browser/gpu/gpu_mode_m...
File chrome/browser/gpu/gpu_mode_manager.h (right):

https://codereview.chromium.org/12593005/diff/1/chrome/browser/gpu/gpu_mode_m...
chrome/browser/gpu/gpu_mode_manager.h:8: #include <string>
On 2013/03/08 23:29:10, Lei Zhang wrote:
> not needed?

Done.

https://codereview.chromium.org/12593005/diff/1/chrome/browser/gpu/gpu_mode_m...
chrome/browser/gpu/gpu_mode_manager.h:10: #include "base/compiler_specific.h"
On 2013/03/08 23:29:10, Lei Zhang wrote:
> You just need basictypes.h here, I think.

Actually I need nothing here.  Removed.

https://codereview.chromium.org/12593005/diff/1/chrome/browser/gpu/gpu_mode_m...
chrome/browser/gpu/gpu_mode_manager.h:20: virtual ~GpuModeManager();
On 2013/03/08 23:29:10, Lei Zhang wrote:
> virtual not needed?

Done.

[Lei Zhang, 2013-03-09 00:23:42]

lgtm once you get approvals for the options and gpu bits.

https://codereview.chromium.org/12593005/diff/18001/chrome/browser/gpu/gpu_mo...
File chrome/browser/gpu/gpu_mode_manager.cc (right):

https://codereview.chromium.org/12593005/diff/18001/chrome/browser/gpu/gpu_mo...
chrome/browser/gpu/gpu_mode_manager.cc:39: void
GpuModeManager::OnGpuModeEnabledPrefChanged() {
Remove this too?

[Zhenyao Mo, 2013-03-09 00:30:48]

https://codereview.chromium.org/12593005/diff/18001/chrome/browser/gpu/gpu_mo...
File chrome/browser/gpu/gpu_mode_manager.cc (right):

https://codereview.chromium.org/12593005/diff/18001/chrome/browser/gpu/gpu_mo...
chrome/browser/gpu/gpu_mode_manager.cc:39: void
GpuModeManager::OnGpuModeEnabledPrefChanged() {
On 2013/03/09 00:23:43, Lei Zhang wrote:
> Remove this too?

Done.

[zmo, 2013-03-11 18:01:46]

jhawkins, apatrick: ping.

[Zhenyao Mo, 2013-03-12 16:35:19]

Also add dbeam and estade.  Please have a look at the option related code.

[Evan Stade, 2013-03-12 19:23:29]

settings lgtm

[apatrick_chromium, 2013-03-12 22:08:22]

gpu things LGTM

[Zhenyao Mo, 2013-03-12 22:32:25]

Committed patchset #3 manually as r187666 (presubmit successful).