Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1259253009: Revert of Attach a SecurityStyle to each request in ResourceLoader (Closed)

Created:
5 years, 4 months ago by estark
Modified:
5 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, lgarron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Attach a SecurityStyle to each request in ResourceLoader (patchset #9 id:160001 of https://codereview.chromium.org/1244863003/) Reason for revert: SecurityStyleChanged browser test is flaky after this change: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests Original issue's description: > Attach a SecurityStyle to each request in ResourceLoader > > This CL adds a SecurityStyle to the serialized security information that > is sent with each request from the browser to the renderer. The > SecurityStyle describes the individual resource, not any bigger-picture > concerns like mixed content. The per-request SecurityStyle will be > displayed in DevTools to help developers diagnose SSL issues on > subresources. > > BUG=502118, 445234 > > Committed: https://crrev.com/5318895a4dd623caf5d152461684935c6e874e12 > Cr-Commit-Position: refs/heads/master@{#340762} TBR=creis@chromium.org,davidben@chromium.org,palmer@chromium.org,msw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=502118, 445234 Committed: https://crrev.com/0c388aaf008fe3549e436fdfa3b2d2ee95b9a011 Cr-Commit-Position: refs/heads/master@{#340785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -355 lines) Patch
M chrome/browser/ui/browser_browsertest.cc View 5 chunks +10 lines, -33 lines 0 comments Download
M content/browser/loader/resource_loader.cc View 5 chunks +40 lines, -49 lines 0 comments Download
M content/browser/loader/resource_loader_unittest.cc View 5 chunks +0 lines, -124 lines 0 comments Download
M content/browser/ssl/ssl_manager.h View 1 chunk +1 line, -6 lines 0 comments Download
M content/browser/ssl/ssl_manager.cc View 2 chunks +5 lines, -12 lines 0 comments Download
M content/browser/ssl/ssl_policy.h View 2 chunks +4 lines, -13 lines 0 comments Download
M content/browser/ssl/ssl_policy.cc View 4 chunks +23 lines, -27 lines 0 comments Download
M content/common/ssl_status_serialization.h View 1 chunk +12 lines, -9 lines 0 comments Download
M content/common/ssl_status_serialization.cc View 3 chunks +15 lines, -36 lines 0 comments Download
M content/common/ssl_status_serialization_unittest.cc View 2 chunks +23 lines, -42 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
estark
Created Revert of Attach a SecurityStyle to each request in ResourceLoader
5 years, 4 months ago (2015-07-28 22:39:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259253009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259253009/1
5 years, 4 months ago (2015-07-28 22:41:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-28 22:42:56 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 22:43:29 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c388aaf008fe3549e436fdfa3b2d2ee95b9a011
Cr-Commit-Position: refs/heads/master@{#340785}

Powered by Google App Engine
This is Rietveld 408576698