third_party/libxml/BUILD.gn - Issue 1259253006: Reland of Enable C4018 globally for the GN build, and disable per-target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libxml/BUILD.gn

Issue 1259253006: Reland of Enable C4018 globally for the GN build, and disable per-target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/libxml/BUILD.gn

diff --git a/third_party/libxml/BUILD.gn b/third_party/libxml/BUILD.gn

index 1f10dee5889d545ecb672337e083253c172e51bb..58a5f1c1040d3ae8ad8909da52d7d56c84c4c191 100644

--- a/third_party/libxml/BUILD.gn

+++ b/third_party/libxml/BUILD.gn

@@ -155,7 +155,10 @@

]

if (is_win) {

- cflags_c = [ "/wd4101" ] # Unreferenced local variable.

+ cflags_c = [

+ "/wd4018", # Signed/unsigned mismatch in comparison.

+ "/wd4101", # Unreferenced local variable.

+ ]

} else if (is_mac || is_ios || is_android) {

# http://www.xmlsoft.org/threads.html says that this is required when using

# libxml from several threads, which can possibly happen in chrome. On

« no previous file with comments | « third_party/libexif/BUILD.gn ('k') | third_party/mesa/BUILD.gn » ('j') | no next file with comments »