Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: third_party/libxml/BUILD.gn

Issue 1259253006: Reland of Enable C4018 globally for the GN build, and disable per-target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/libexif/BUILD.gn ('k') | third_party/mesa/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Define an "os_include" variable that points at the OS-specific generated 5 # Define an "os_include" variable that points at the OS-specific generated
6 # headers. These were generated by running the configure script offline. 6 # headers. These were generated by running the configure script offline.
7 if (is_linux || is_android || is_nacl) { 7 if (is_linux || is_android || is_nacl) {
8 os_include = "linux" 8 os_include = "linux"
9 } else if (is_mac || is_ios) { 9 } else if (is_mac || is_ios) {
10 os_include = "mac" 10 os_include = "mac"
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 148
149 public_configs = [ ":libxml_config" ] 149 public_configs = [ ":libxml_config" ]
150 public_deps = [ 150 public_deps = [
151 "//third_party/icu:icuuc", 151 "//third_party/icu:icuuc",
152 ] 152 ]
153 deps = [ 153 deps = [
154 "//third_party/zlib", 154 "//third_party/zlib",
155 ] 155 ]
156 156
157 if (is_win) { 157 if (is_win) {
158 cflags_c = [ "/wd4101" ] # Unreferenced local variable. 158 cflags_c = [
159 "/wd4018", # Signed/unsigned mismatch in comparison.
160 "/wd4101", # Unreferenced local variable.
161 ]
159 } else if (is_mac || is_ios || is_android) { 162 } else if (is_mac || is_ios || is_android) {
160 # http://www.xmlsoft.org/threads.html says that this is required when using 163 # http://www.xmlsoft.org/threads.html says that this is required when using
161 # libxml from several threads, which can possibly happen in chrome. On 164 # libxml from several threads, which can possibly happen in chrome. On
162 # linux, this is picked up by transitivity from pkg-config output from 165 # linux, this is picked up by transitivity from pkg-config output from
163 # build/linux/system.gyp. 166 # build/linux/system.gyp.
164 defines = [ "_REENTRANT" ] 167 defines = [ "_REENTRANT" ]
165 } 168 }
166 169
167 if (is_clang) { 170 if (is_clang) {
168 cflags = [ 171 cflags = [
(...skipping 22 matching lines...) Expand all
191 # libxml passes a volatile LPCRITICAL_SECTION* to a function expecting 194 # libxml passes a volatile LPCRITICAL_SECTION* to a function expecting
192 # a void* volatile*. 195 # a void* volatile*.
193 "-Wno-incompatible-pointer-types", 196 "-Wno-incompatible-pointer-types",
194 ] 197 ]
195 } 198 }
196 } 199 }
197 configs += [ ":libxml_warnings" ] 200 configs += [ ":libxml_warnings" ]
198 201
199 include_dirs = [ "$os_include" ] 202 include_dirs = [ "$os_include" ]
200 } 203 }
OLDNEW
« no previous file with comments | « third_party/libexif/BUILD.gn ('k') | third_party/mesa/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698