Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: third_party/libexif/BUILD.gn

Issue 1259253006: Reland of Enable C4018 globally for the GN build, and disable per-target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/leveldatabase/BUILD.gn ('k') | third_party/libxml/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Linux should use system libexif 5 # Linux should use system libexif
6 if (!is_linux || is_chromeos) { 6 if (!is_linux || is_chromeos) {
7 # TODO(thestig): Properly support building on Linux. 7 # TODO(thestig): Properly support building on Linux.
8 config("libexif_config") { 8 config("libexif_config") {
9 include_dirs = [ "sources" ] 9 include_dirs = [ "sources" ]
10 if (is_clang) { 10 if (is_clang) {
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 53
54 if (is_win) { 54 if (is_win) {
55 defines = [ 55 defines = [
56 # This seems like a hack, but this is what WebKit Win does. 56 # This seems like a hack, but this is what WebKit Win does.
57 "snprintf=_snprintf", 57 "snprintf=_snprintf",
58 "inline=__inline", 58 "inline=__inline",
59 ] 59 ]
60 60
61 ldflags = [ "/DEF:" + rebase_path("libexif.def") ] 61 ldflags = [ "/DEF:" + rebase_path("libexif.def") ]
62 62
63 cflags = [ "/wd4018" ] # size/unsigned mismatch 63 cflags = [ "/wd4018" ] # Signed/unsigned mismatch in comparison.
64 64
65 # TODO(GYP): Handle /analyze switch, when it will be used in GN. 65 # TODO(GYP): Handle /analyze switch, when it will be used in GN.
66 } else if (is_linux) { 66 } else if (is_linux) {
67 libs = [ "m" ] 67 libs = [ "m" ]
68 } 68 }
69 69
70 configs -= [ "//build/config/compiler:chromium_code" ] 70 configs -= [ "//build/config/compiler:chromium_code" ]
71 configs += [ "//build/config/compiler:no_chromium_code" ] 71 configs += [ "//build/config/compiler:no_chromium_code" ]
72 72
73 public_configs = [ ":libexif_config" ] 73 public_configs = [ ":libexif_config" ]
74 } 74 }
75 } 75 }
OLDNEW
« no previous file with comments | « third_party/leveldatabase/BUILD.gn ('k') | third_party/libxml/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698