Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1487)

Side by Side Diff: third_party/leveldatabase/BUILD.gn

Issue 1259253006: Reland of Enable C4018 globally for the GN build, and disable per-target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/filesystem/file_impl.cc ('k') | third_party/libexif/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//testing/test.gni") 5 import("//testing/test.gni")
6 6
7 defines = [ "LEVELDB_PLATFORM_CHROMIUM=1" ] 7 defines = [ "LEVELDB_PLATFORM_CHROMIUM=1" ]
8 8
9 config("leveldatabase_config") { 9 config("leveldatabase_config") {
10 include_dirs = [ 10 include_dirs = [
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 configs += [ "//build/config/compiler:no_chromium_code" ] 107 configs += [ "//build/config/compiler:no_chromium_code" ]
108 108
109 public_configs = [ ":leveldatabase_config" ] 109 public_configs = [ ":leveldatabase_config" ]
110 110
111 deps = [ 111 deps = [
112 "//base", 112 "//base",
113 "//base/third_party/dynamic_annotations", 113 "//base/third_party/dynamic_annotations",
114 "//third_party/re2", 114 "//third_party/re2",
115 "//third_party/snappy", 115 "//third_party/snappy",
116 ] 116 ]
117
118 if (is_win) {
119 cflags = [ "/wd4018" ] # Signed/unsigned mismatch in comparison.
120 }
117 } 121 }
118 122
119 if (!is_android) { 123 if (!is_android) {
120 test("env_chromium_unittests") { 124 test("env_chromium_unittests") {
121 sources = [ 125 sources = [
122 "env_chromium_unittest.cc", 126 "env_chromium_unittest.cc",
123 ] 127 ]
124 deps = [ 128 deps = [
125 ":leveldatabase", 129 ":leveldatabase",
126 "//base/test:test_support", 130 "//base/test:test_support",
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 sources = [ 322 sources = [
319 "src/db/write_batch_test.cc", 323 "src/db/write_batch_test.cc",
320 ] 324 ]
321 configs -= [ "//build/config/compiler:chromium_code" ] 325 configs -= [ "//build/config/compiler:chromium_code" ]
322 configs += [ "//build/config/compiler:no_chromium_code" ] 326 configs += [ "//build/config/compiler:no_chromium_code" ]
323 deps = [ 327 deps = [
324 ":leveldb_testutil", 328 ":leveldb_testutil",
325 ] 329 ]
326 } 330 }
327 } 331 }
OLDNEW
« no previous file with comments | « components/filesystem/file_impl.cc ('k') | third_party/libexif/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698