Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1259253006: Reland of Enable C4018 globally for the GN build, and disable per-target. (Closed)

Created:
5 years, 4 months ago by Peter Kasting
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Enable C4018 globally for the GN build, and disable per-target. (patchset #1 id:1 of https://codereview.chromium.org/1257583007/) Reason for revert: I believe the GN build failure was caused by a different patch of brettw's. Original issue's description: > Revert of Enable C4018 globally for the GN build, and disable per-target. (patchset #4 id:60001 of https://codereview.chromium.org/1246103007/) > > Reason for revert: > Speculative revert based on windows gn bots failing with > > http://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/10113 > > FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/base/base/precompile.c.obj.rsp /c ../../build/precompile.cc /Foobj/base/base/precompile.c.obj /Fdobj/base/base_c.pdb > e:\b\build\slave\win_x64_gn__dbg_\build\src\build\precompile.cc(8) : error C2220: warning treated as error - no 'object' file generated > e:\b\build\slave\win_x64_gn__dbg_\build\src\build\precompile.cc(8) : warning C4206: nonstandard extension used : translation unit is empty > ninja: build stopped: subcommand failed. > > In theory this warning shouldn't have affected other warnings, but there are no other clear candidates. > > Original issue's description: > > Enable C4018 globally for the GN build, and disable per-target. > > > > This matches what the GYP build does. > > > > BUG=398202 > > TEST=none > > > > Committed: https://crrev.com/d408e1965f8e03629738039289ab7779c42a318c > > Cr-Commit-Position: refs/heads/master@{#340590} > > TBR=brettw@chromium.org,erg@chromium.org,pkasting@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=398202 > > Committed: https://crrev.com/4bf2ca554347fc20e1649e5ff4cf700d9fbd713a > Cr-Commit-Position: refs/heads/master@{#340623} TBR=brettw@chromium.org,erg@chromium.org,ccameron@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=398202 Committed: https://crrev.com/0d79de12da6b9fcb6f2b6337064637bd1ad05ba5 Cr-Commit-Position: refs/heads/master@{#340745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -14 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M components/filesystem/file_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/leveldatabase/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/libexif/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/mesa/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/protobuf/BUILD.gn View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/qcms/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/re2/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/snappy/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Kasting
Created Reland of Enable C4018 globally for the GN build, and disable per-target.
5 years, 4 months ago (2015-07-28 19:17:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259253006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259253006/1
5 years, 4 months ago (2015-07-28 19:19:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-28 19:21:20 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 19:22:13 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d79de12da6b9fcb6f2b6337064637bd1ad05ba5
Cr-Commit-Position: refs/heads/master@{#340745}

Powered by Google App Engine
This is Rietveld 408576698