Issue 1259253002: Fix adb path being used in `mojo_run`.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1259253002: Fix adb path being used in `mojo_run`. (Closed)

Created:
5 years, 4 months ago by ppi

Modified:
5 years, 4 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix adb path being used in `mojo_run`. When running within a Chromium-like checkout, we need to use the adb path inferred from the checkout. Setting a default value for --adb-path to "adb" in d7994c78e260df041d421b2b759bde55df38d1f2 was a bad idea, as the command line override always beats the inferred path. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b9f084ad3be8e9f253cb1d9922f3a50506d6a428

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	mojo/devtools/common/devtoolslib/shell_arguments.py	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	mojo/devtools/common/mojo_run	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ppi

5 years, 4 months ago (2015-07-28 12:45:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
b9f084ad3be8e9f253cb1d9922f3a50506d6a428 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages