Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: runtime/vm/store_buffer.h

Issue 1259223005: Safepoint interface and unit tests. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Add comment about overflow. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/store_buffer.h
diff --git a/runtime/vm/store_buffer.h b/runtime/vm/store_buffer.h
index b8f36a5e369d70a791d07f16db9eccd25d048dfe..b1bd387e8fb87d8d657fd0a310adf5a94528ca57 100644
--- a/runtime/vm/store_buffer.h
+++ b/runtime/vm/store_buffer.h
@@ -97,6 +97,9 @@ class StoreBuffer {
// Discards the contents of this store buffer.
void Reset();
+ // Check whether non-empty blocks have exceeded kMaxNonEmpty.
+ bool Overflowed();
+
private:
class List {
public:
@@ -113,10 +116,6 @@ class StoreBuffer {
DISALLOW_COPY_AND_ASSIGN(List);
};
- // Check if we run over the max number of deduplication sets.
- // If we did schedule an interrupt.
- void CheckThresholdNonEmpty();
-
// If needed, trims the the global cache of empty blocks.
static void TrimGlobalEmpty();
« no previous file with comments | « runtime/vm/isolate.h ('k') | runtime/vm/store_buffer.cc » ('j') | runtime/vm/thread_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698