Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: content/child/service_worker/web_service_worker_provider_impl.cc

Issue 1259213002: Move Service Worker %2f path validation logic from browser into Blink (1) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix remaining nits. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/service_worker/web_service_worker_provider_impl.cc
diff --git a/content/child/service_worker/web_service_worker_provider_impl.cc b/content/child/service_worker/web_service_worker_provider_impl.cc
index 154dfe0281aae8a717387ef8bd2dd79bc7e73ee0..a0472cced16526aeeb1a93de8c8f1a2eda3d7aac 100644
--- a/content/child/service_worker/web_service_worker_provider_impl.cc
+++ b/content/child/service_worker/web_service_worker_provider_impl.cc
@@ -9,6 +9,7 @@
#include "content/child/service_worker/service_worker_provider_context.h"
#include "content/child/service_worker/web_service_worker_impl.h"
#include "content/child/thread_safe_sender.h"
+#include "content/common/service_worker/service_worker_utils.h"
#include "third_party/WebKit/public/platform/WebServiceWorkerProviderClient.h"
#include "third_party/WebKit/public/platform/WebURL.h"
@@ -76,6 +77,18 @@ void WebServiceWorkerProviderImpl::getRegistrationForReady(
GetDispatcher()->GetRegistrationForReady(context_->provider_id(), callbacks);
}
+bool WebServiceWorkerProviderImpl::validateScopeAndScriptURL(
+ const blink::WebURL& scope,
+ const blink::WebURL& script_url,
+ blink::WebString* error_message) {
+ std::string error;
+ bool has_error = ServiceWorkerUtils::ContainsDisallowedCharacter(
+ scope, script_url, &error);
+ if (has_error)
+ *error_message = blink::WebString::fromUTF8(error);
+ return !has_error;
+}
+
int WebServiceWorkerProviderImpl::provider_id() const {
return context_->provider_id();
}
« no previous file with comments | « content/child/service_worker/web_service_worker_provider_impl.h ('k') | content/common/service_worker/service_worker_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698