Move Service Worker %2f path validation logic from browser into Blink (1)

content/child/service_worker/web_service_worker_provider_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/service_worker/web_service_worker_provider_impl.h"
 
 #include "content/child/service_worker/service_worker_dispatcher.h"
 #include "content/child/service_worker/service_worker_handle_reference.h"
 #include "content/child/service_worker/service_worker_provider_context.h"
 #include "content/child/service_worker/web_service_worker_impl.h"
@@ skipping 58 matching lines @@
     WebServiceWorkerGetRegistrationsCallbacks* callbacks) {
   GetDispatcher()->GetRegistrations(
       context_->provider_id(), callbacks);
 }
 
 void WebServiceWorkerProviderImpl::getRegistrationForReady(
     WebServiceWorkerGetRegistrationForReadyCallbacks* callbacks) {
   GetDispatcher()->GetRegistrationForReady(context_->provider_id(), callbacks);
 }
 
+bool WebServiceWorkerProviderImpl::areScopeAndScriptURLValid(
+    const blink::WebURL& scope,
+    const blink::WebURL& script_url,
+    WTF::String* error_message) {
+  return !ServiceWorkerUtils::ContainsDisallowedCharacter(

[nhiroki, 2015/07/28 09:16:03]

This is a module dependency violation. We cannot include content/browser/* from
content/child/*. Can you move ServiceWorkerUtils into content/common/ which can
be accessed from content/{browser,child,renderer}/?

+      pattern->GURL(), script_url->GURL(), error_message);
+}
+
 int WebServiceWorkerProviderImpl::provider_id() const {
   return context_->provider_id();
 }
 
 void WebServiceWorkerProviderImpl::RemoveProviderClient() {
   // Remove the provider client, but only if the dispatcher is still there.
   // (For cleanup path we don't need to bother creating a new dispatcher)
   ServiceWorkerDispatcher* dispatcher =
       ServiceWorkerDispatcher::GetThreadSpecificInstance();
   if (dispatcher)
     dispatcher->RemoveProviderClient(context_->provider_id());
 }
 
 ServiceWorkerDispatcher* WebServiceWorkerProviderImpl::GetDispatcher() {
   return ServiceWorkerDispatcher::GetThreadSpecificInstance();
 }
 
 }  // namespace content