Issue 12592002: Revert "Send SIGPROF signals on the profiler event processor thread"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12592002: Revert "Send SIGPROF signals on the profiler event processor thread" (Closed)

Created:
7 years, 9 months ago by yurys

Modified:
7 years, 9 months ago

Reviewers:
Yang, Jakob Kummerow

CC:
chromium-reviews, loislo, pfeldman

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Send SIGPROF signals on the profiler event processor thread" This reverts commit r13735 as CPU profiler data is inaccurate after that change. BUG=v8:2571 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=13851

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -322 lines)			Patch
M	src/circular-queue.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/circular-queue.cc	View	2 chunks	+8 lines, -12 lines	0 comments	Download
M	src/cpu-profiler.h	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	src/cpu-profiler.cc	View	5 chunks	+11 lines, -45 lines	0 comments	Download
M	src/flag-definitions.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/platform.h	View	3 chunks	+4 lines, -25 lines	0 comments	Download
M	src/platform-cygwin.cc	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	src/platform-freebsd.cc	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	src/platform-linux.cc	View	10 chunks	+39 lines, -98 lines	0 comments	Download
M	src/platform-macos.cc	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	src/platform-nullos.cc	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	src/platform-openbsd.cc	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	src/platform-solaris.cc	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	src/platform-win32.cc	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	test/cctest/test-cpu-profiler.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

yurys

7 years, 9 months ago (2013-03-07 09:13:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r13851 (presubmit successful).