Chromium Code Reviews

Issue 1259183005: [es6] new.target should not be shadowable in a with scope (Closed)

Created:
5 years, 4 months ago by adamk
Modified:
5 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] new.target should not be shadowable in a with scope BUG=v8:3887 LOG=n Committed: https://crrev.com/c4247c1bc25a9a3c95f6ceb90c255b4530e4bb89 Cr-Commit-Position: refs/heads/master@{#30010}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+4 lines, -2 lines)
M src/ast.h View 1 chunk +1 line, -1 line 0 comments
M src/ast-value-factory.h View 1 chunk +1 line, -1 line 0 comments
M test/mjsunit/harmony/new-target.js View 1 chunk +2 lines, -0 lines 0 comments

Messages

Total messages: 8 (2 generated)
adamk
5 years, 4 months ago (2015-08-03 22:24:07 UTC) #2
adamk
Note that this approach (adding a leading '.') may need to change depending on what ...
5 years, 4 months ago (2015-08-03 22:38:55 UTC) #3
rossberg
lgtm
5 years, 4 months ago (2015-08-04 12:41:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259183005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259183005/1
5 years, 4 months ago (2015-08-04 17:13:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-04 17:15:39 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 17:16:09 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c4247c1bc25a9a3c95f6ceb90c255b4530e4bb89
Cr-Commit-Position: refs/heads/master@{#30010}

Powered by Google App Engine