include/core/SkTArray.h - Issue 1259143006: Remove unnecessary virtual destructor on SkTArray

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkTArray.h

Issue 1259143006: Remove unnecessary virtual destructor on SkTArray (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkTArray.h

diff --git a/include/core/SkTArray.h b/include/core/SkTArray.h

index a035f6e9afb3aa96690b41c7c57cb2473f4b196c..4bf1d70c6bf69cfbcf7f4544125a58f7714bbc81 100644

--- a/include/core/SkTArray.h

+++ b/include/core/SkTArray.h

@@ -107,7 +107,7 @@ public:

return *this;

}

- virtual ~SkTArray() {

+ ~SkTArray() {

for (int i = 0; i < fCount; ++i) {

fItemArray[i].~T();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »