Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1259123003: Update Android Testing apps to support release mode (Closed)

Created:
5 years, 4 months ago by djsollen
Modified:
5 years, 4 months ago
Reviewers:
bungeman-skia, borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update Android Testing apps to support release mode BUG=skia:4152 Committed: https://skia.googlesource.com/skia/+/5119ac069e6cf70175b5581eedee7d07347b216a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M platform_tools/android/bin/android_install_app View 1 chunk +10 lines, -3 lines 1 comment Download
M platform_tools/android/bin/android_setup.sh View 1 chunk +1 line, -0 lines 0 comments Download
M platform_tools/android/gyp/skia_android.gypi View 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
djsollen
5 years, 4 months ago (2015-07-31 16:20:14 UTC) #2
borenet
LGTM with question https://codereview.chromium.org/1259123003/diff/1/platform_tools/android/bin/android_install_app File platform_tools/android/bin/android_install_app (right): https://codereview.chromium.org/1259123003/diff/1/platform_tools/android/bin/android_install_app#newcode57 platform_tools/android/bin/android_install_app:57: if [[ "$BUILDTYPE" == "Release" ]]; ...
5 years, 4 months ago (2015-07-31 16:57:43 UTC) #3
djsollen
On 2015/07/31 16:57:43, borenet wrote: > LGTM with question > > https://codereview.chromium.org/1259123003/diff/1/platform_tools/android/bin/android_install_app > File platform_tools/android/bin/android_install_app ...
5 years, 4 months ago (2015-07-31 17:18:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259123003/1
5 years, 4 months ago (2015-07-31 17:18:36 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 17:25:19 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5119ac069e6cf70175b5581eedee7d07347b216a

Powered by Google App Engine
This is Rietveld 408576698