Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 1259103004: Fix silly mistake in allocating geoms in TextBatch (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 4 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/GrAtlasTextContext.cpp View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 6 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259103004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259103004/1
5 years, 4 months ago (2015-07-29 13:40:18 UTC) #2
joshualitt
On 2015/07/29 13:40:18, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 4 months ago (2015-07-29 13:43:54 UTC) #3
joshualitt
https://codereview.chromium.org/1259103004/diff/1/src/gpu/GrAtlasTextContext.cpp File src/gpu/GrAtlasTextContext.cpp (right): https://codereview.chromium.org/1259103004/diff/1/src/gpu/GrAtlasTextContext.cpp#newcode1931 src/gpu/GrAtlasTextContext.cpp:1931: int currAllocSize = SkTMax<int>(kMinGeometryAllocated, GrNextPow2(fGeoCount)); Actually, I'm not sure ...
5 years, 4 months ago (2015-07-29 13:45:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/16ed6adb65e09fdb486a9c8e9c07505c26f5c34e
5 years, 4 months ago (2015-07-29 13:54:39 UTC) #5
bsalomon
5 years, 4 months ago (2015-07-29 14:14:46 UTC) #6
Message was sent while issue was closed.
On 2015/07/29 13:45:10, joshualitt wrote:
>
https://codereview.chromium.org/1259103004/diff/1/src/gpu/GrAtlasTextContext.cpp
> File src/gpu/GrAtlasTextContext.cpp (right):
> 
>
https://codereview.chromium.org/1259103004/diff/1/src/gpu/GrAtlasTextContext....
> src/gpu/GrAtlasTextContext.cpp:1931: int currAllocSize =
> SkTMax<int>(kMinGeometryAllocated, GrNextPow2(fGeoCount));
> Actually, I'm not sure I like the use of 'size' here.  Size makes me think
> bytes.

will rename as count

Powered by Google App Engine
This is Rietveld 408576698