Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1259103002: Revert "Compile and link libcrypto_nacl for nacl targets." (Closed)

Created:
5 years, 4 months ago by erikchen
Modified:
5 years, 4 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Compile and link libcrypto_nacl for nacl targets." I restructured the new ipc attachment broker code to not expose any crypto symbols to irt targets, so the original CL is no longer needed. > NaCl depends on libipc_nacl, which recently started depending on libcrypto_nacl. > I failed to update the NaCl build files appropriately. > > BUG=466437 > Committed: https://crrev.com/675c4a0b28eb5b8e922153af2feb1ff68b635eb7 > Cr-Commit-Position: refs/heads/master@{#339558} BUG=466437 TBR=agl@chromium.org, mseaborn@chromium.org Committed: https://crrev.com/3e4cf54491803eb102c4887f1de5ccd088c612b1 Cr-Commit-Position: refs/heads/master@{#340622}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M crypto/crypto_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/native_client.gyp View 6 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259103002/1
5 years, 4 months ago (2015-07-27 20:54:58 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-27 22:32:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259103002/1
5 years, 4 months ago (2015-07-28 00:59:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-28 01:04:09 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3e4cf54491803eb102c4887f1de5ccd088c612b1 Cr-Commit-Position: refs/heads/master@{#340622}
5 years, 4 months ago (2015-07-28 01:04:59 UTC) #8
Mark Seaborn
5 years, 4 months ago (2015-07-28 21:12:00 UTC) #9
Message was sent while issue was closed.
BTW, this change says "TBR=mseaborn", but there's no-one in the Reviewers and CC
fields, so I didn't get an e-mail about this.

LGTM though. :-)

Powered by Google App Engine
This is Rietveld 408576698