Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2172)

Unified Diff: chrome/browser/ui/webui/media_router/media_router_ui.cc

Issue 1259073004: [Presentation API] Change ListenForSessionMessages API to client-style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/media_router/media_router_ui.cc
diff --git a/chrome/browser/ui/webui/media_router/media_router_ui.cc b/chrome/browser/ui/webui/media_router/media_router_ui.cc
index 8d717f5baf704283faa881c461c667549cd98167..09509fc7e0eb4b4c09cf4ee713d34e724cd5514d 100644
--- a/chrome/browser/ui/webui/media_router/media_router_ui.cc
+++ b/chrome/browser/ui/webui/media_router/media_router_ui.cc
@@ -38,12 +38,16 @@ namespace {
void HandleRouteResponseForPresentationApi(
scoped_ptr<CreatePresentationSessionRequest> presentation_request,
const MediaRoute* route,
+ const std::string& presentation_id,
const std::string& error) {
DCHECK(presentation_request);
if (!route) {
presentation_request->MaybeInvokeErrorCallback(
content::PresentationError(content::PRESENTATION_ERROR_UNKNOWN, error));
} else {
+ // Presentation ID should not have changed.
+ DCHECK_EQ(presentation_request->presentation_info().presentation_id,
+ presentation_id);
presentation_request->MaybeInvokeSuccessCallback(route->media_route_id());
}
}
@@ -282,6 +286,7 @@ void MediaRouterUI::OnRoutesUpdated(const std::vector<MediaRoute>& routes) {
}
void MediaRouterUI::OnRouteResponseReceived(const MediaRoute* route,
+ const std::string& presentation_id,
const std::string& error) {
DVLOG(1) << "OnRouteResponseReceived";
// TODO(imcheng): Display error in UI. (crbug.com/490372)

Powered by Google App Engine
This is Rietveld 408576698